Modify

Opened 11 years ago

Closed 11 years ago

Last modified 7 years ago

#9039 closed enhancement (fixed)

[patch] add support for shop=gift, shop=car_parts, shop=beauty

Reported by: aceman Owned by: team
Priority: normal Milestone: 13.11
Component: Internal preset Version: latest
Keywords: beauty car_parts gift Cc:

Description (last modified by skyper)

Add support for shop=gift, shop=car_parts, shop=beauty, make them be matched by a preset and use some icon to indicate they are known types.

All of them thousands of uses:
http://wiki.openstreetmap.org/wiki/Tag:shop%3Dgift
http://wiki.openstreetmap.org/wiki/Tag:shop%3Dcar_parts
http://wiki.openstreetmap.org/wiki/Tag:shop%3Dbeauty

Attachments (3)

josm_9039.diff (7.5 KB ) - added by skyper 11 years ago.
patch
josm_9039_v2.diff (15.6 KB ) - added by skyper 11 years ago.
patch version 2
josm_9039_gift+car_parts.diff (22.9 KB ) - added by skyper 11 years ago.
patch for gift + car_parts + fixes

Download all attachments as: .zip

Change History (21)

comment:1 by aceman, 11 years ago

Sorry, the proper spelling seems to be shop=gift.

comment:2 by skyper, 11 years ago

Description: modified (diff)
Keywords: beaty car_parts gift added
Priority: minornormal
Summary: add support for shop=gifts, shop=car_parts, shop=beautyadd support for shop=gift, shop=car_parts, shop=beauty

comment:3 by skyper, 11 years ago

For shop=beauty see also #8397.

comment:4 by skyper, 11 years ago

Owner: changed from team to skyper

Can anyone suggest some icons (if possible .svg), please ?

by skyper, 11 years ago

Attachment: josm_9039.diff added

patch

comment:5 by skyper, 11 years ago

Owner: changed from skyper to team
Summary: add support for shop=gift, shop=car_parts, shop=beauty[patch] add support for shop=gift, shop=car_parts, shop=beauty

Find attached patch which introduces the three new items plus small fixes and updates.

Did only find an icon for "gift" so far. (openclipart)

At least an icon for "beauty" is missing.

by skyper, 11 years ago

Attachment: josm_9039_v2.diff added

patch version 2

comment:6 by skyper, 11 years ago

Sorry, I did copy and paste many unneeded white spaces.

Find attached version 2 which also deletes more quite spaces at the end of line.

comment:7 by aceman, 11 years ago

Looks good to me. Only that I don't see "beauty:type" key being used anywhere. Where did you get it from? According to taginfo people stick the type under a "beauty" key for now...

in reply to:  7 comment:8 by skyper, 11 years ago

Replying to aceman:

Looks good to me. Only that I don't see "beauty:type" key being used anywhere. Where did you get it from? According to taginfo people stick the type under a "beauty" key for now...

Oh sure, I forgot to mention. Thanks for reminding.
I am not sure about "beauty=*" as it does not seem to be a good tag as it might be misleading, especially thinking about translation and if taken out of context.

On the other hand we could even deprecate shop=hairdresser now and move it under shop=beauty.

comment:9 by aceman, 11 years ago

So does it mean you invent the beauty:type key here?

Shop=hairdresser is used 55000 times (about 10 times more than "beauty") and is the fifth most popular value of "shop". I don't think we should deprecate it right now and the wiki also does not indicate any decision on deprecating it. Please don't do it.

in reply to:  9 comment:10 by skyper, 11 years ago

Replying to aceman:

So does it mean you invent the beauty:type key here?

Yes, but ok I can remove it.
The more I look at the issue the more I fear, we need better documentation first. Is it a shop for beauty services like manicure, make-up etc. or is it a shop where you get beauty products. When to use special tags like shop=hairdresser, shop=massage, shop=drugstore, shop=barber, shop=solarium. Overall is this really a shop or a leisure ?
At least useful values for beauty=* are needed.

Shop=hairdresser is used 55000 times (about 10 times more than "beauty") and is the fifth most popular value of "shop". I don't think we should deprecate it right now and the wiki also does not indicate any decision on deprecating it. Please don't do it.

Was just a thought without intension to change for now.

Best for now is to divide the patch and move the beauty part to #8397.

by skyper, 11 years ago

patch for gift + car_parts + fixes

comment:11 by skyper, 11 years ago

I did attach a new patch which covers shop=car_parts, shop=gift, an update of the optional docu, small update of shop=car and quite some space clean up of shop section.

Last edited 11 years ago by skyper (previous) (diff)

comment:12 by aceman, 11 years ago

Yes, I am OK with this patch.

comment:13 by mdk, 11 years ago

Keywords: beauty added; beaty removed

comment:14 by aceman, 11 years ago

Any chance of checking this in?

comment:15 by skyper, 11 years ago

ping

comment:16 by stoecker, 11 years ago

Resolution: fixed
Status: newclosed

In 6249/josm:

fix #9039 - some preset cleanups

comment:17 by Don-vip, 10 years ago

Milestone: 13.11 (6383)

comment:18 by stoecker, 7 years ago

Milestone: 13.11 (6383)13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.