Modify

Opened 11 years ago

Closed 11 years ago

#9025 closed enhancement (worksforme)

unglue POIs

Reported by: dieterdreist Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

there is a regression for unglueing POIs (nodes with tags), now if you unglue a POI at a crossing all ways get unglued and the tags remain at all new end-nodes. Before only the POI was unglued (desired behaviour)

Attachments (2)

9025-test1.osm (938 bytes ) - added by AlfonZ 11 years ago.
9025-test2.osm (812 bytes ) - added by AlfonZ 11 years ago.
Note: Although nodes and ways have positive IDs, they are fabricated and must not be uploaded!

Download all attachments as: .zip

Change History (10)

comment:1 by Don-vip, 11 years ago

What version are you using ? Do you remember the last version working as you expect ?

comment:2 by dieterdreist, 11 years ago

I'm on 6201, I have checked 6129, 6150, 6187 and they all had the same problem. Maybe this is a side effect of my switch from 1.6 to 1.7 java?
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx8192M, -Dsun.java2d.opengl=true]

by AlfonZ, 11 years ago

Attachment: 9025-test1.osm added

comment:3 by AlfonZ, 11 years ago

Referring to 9025-test1.osm:
Select the traffic_signals node, UnGlue Ways. The node gets duplicated.

I have tried it with JOSM 6201, 6115, and couple of older builds as far as 3208. Same behaviour.
Java version: 1.6.0_45, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) Client VM

in reply to:  3 comment:4 by Don-vip, 11 years ago

Priority: majornormal
Summary: unglue POIs regressionunglue POIs
Type: defectenhancement

Replying to AlfonZ:

I have tried it with JOSM 6201, 6115, and couple of older builds as far as 3208. Same behaviour.

Then it is no regression.

comment:5 by dieterdreist, 11 years ago

I'm quite sure this did work at some point in time.

comment:6 by skyper, 11 years ago

Yes, something did change, but maybe it was some other commit:

Ungluing a POI of a single way (middel node) does not really unglue the POI as the node with ID remains as way node and the POI gets an new ID.

Thought that the node gets complete unglued from way.

by AlfonZ, 11 years ago

Attachment: 9025-test2.osm added

Note: Although nodes and ways have positive IDs, they are fabricated and must not be uploaded!

in reply to:  6 comment:7 by AlfonZ, 11 years ago

Replying to skyper:

Yes, something did change, but maybe it was some other commit:

Ungluing a POI of a single way (middel node) does not really unglue the POI as the node with ID remains as way node and the POI gets an new ID.

Thought that the node gets complete unglued from way.

Referring to 9025-test2.osm:
Select the crossing node (ID 4), UnGlue Ways. The node gets unglued. Old node (still part of way) retains ID 4, no tags; new node is tagged crossing.
I have tried it with JOSM 6266, 6238, 6115 and couple of older builds as far as 1521. Same behaviour.

Maybe you are thinking of utilsplugin2's Extract node, in which the node that is part of the way gets new ID and extracted node retains ID and tags.
Then there is recently added Disconnect Node from Way, in which the node is no longer part of the way.

comment:8 by Don-vip, 11 years ago

Resolution: worksforme
Status: newclosed

Between Unglue, Extract and Disconnect I think you should find the one that matches your need :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.