Modify

Opened 7 years ago

Closed 7 years ago

#8986 closed enhancement (fixed)

[patch] Data loading/bbox index counting optimization

Reported by: shinigami Owned by: team
Priority: major Milestone:
Component: Core Version:
Keywords: performance Cc:

Description

I made few small changes in counting index for bbox and given level, on my testing data and in profiler it seems to run about 6-7x faster now, speedup when loading data is about 20%.

Attachments (1)

quadbucketsindex.diff (5.3 KB) - added by shinigami 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by Don-vip

Nice :) can you also write javadoc for public methods ? Thanks :)

comment:2 Changed 7 years ago by Don-vip

Summary: Data loading/bbox index counting optimization[patch] Data loading/bbox index counting optimization

comment:3 Changed 7 years ago by Don-vip

Keywords: performance added
Priority: normalmajor

Changed 7 years ago by shinigami

Attachment: quadbucketsindex.diff added

comment:4 Changed 7 years ago by shinigami

It's there:).

comment:5 Changed 7 years ago by AlfonZ

If I wanted to be nitpicky, I'd say it should be public static int instead of static public int (in regards to modifiers order coding style enhancement) ;)

comment:6 Changed 7 years ago by Don-vip

How do you measure performance gain ? I'm of course ok to apply this patch but I would be curious to measure it myself before :)

comment:7 Changed 7 years ago by shinigami

I run it in profiler and loaded same files (used files from around my city, all ~30000 nodes with some overlaping). Load time felt from 50s to 40s (I have used full method tracking, so it was slow), index counting parts from about 12s to 2s. But it is is biased by profiler overhead..

comment:8 Changed 7 years ago by Don-vip

alright :)

comment:9 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6171/josm:

fix #8986 - Data loading/bbox index counting optimization (patch by shinigami) + code cleanup in Quad* classes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.