Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8954 closed defect (fixed)

[Patch] Checkboxes not displayed in preset (In Vorlagen werden Checkboxen nicht dargestellt)

Reported by: Zecke Owned by: Don-vip
Priority: normal Milestone:
Component: Core Version: latest
Keywords: template_report preset check Cc: Zecke, wambacher, Don-vip

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Vorlage mit Checkbox verwenden (JOSM 6115 und 6129)
  2. Checkbox wird nicht dargestellt, Comboboxen, Textfelder gehen
  1. Use preset with checkbox (JOSM 6115 and 6129)
  2. Checkbox is not displayed, combos and text work.

Detaillierte Beschreibung (detailed description in German):
http://forum.openstreetmap.org/viewtopic.php?id=22163

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-08-07 01:35:24
Last Changed Author: Don-vip
Revision: 6115
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-08-07 00:04:24 +0200 (Wed, 07 Aug 2013)
Last Changed Rev: 6115

Identification: JOSM/1.5 (6115 de) Windows 7 64-Bit
Memory Usage: 220 MB / 1816 MB (64 MB allocated, but free)
Java version: 1.7.0_21, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Xverify:remote, -Djnlpx.home=C:\Program Files\Java\jre7\bin, -Djnlpx.origFilenameArg=C:\Users\cg\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\21\73111055-564844fd, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Xbootclasspath/a:C:\Program Files\Java\jre7\lib\javaws.jar;C:\Program Files\Java\jre7\lib\deploy.jar;C:\Program Files\Java\jre7\lib\plugin.jar, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=49477, -Djnlp.application.href=http://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=C:\Program Files\Java\jre7\bin\javaw.exe, -Djnlpx.vmargs=-Djava.util.Arrays.useLegacyMergeSort=true -Djnlp.application.href=http://josm.openstreetmap.de/download/josm.jnlp]
Dataset consistency test: No problems found

Plugin: DirectUpload (29778)
Plugin: PicLayer (29809)
Plugin: editgpx (29596)

Attachments (4)

broken_preset.xml (2.5 KB) - added by skyper 6 years ago.
preset
8954.patch (623 bytes) - added by AlfonZ 6 years ago.
8954-test.patch (3.8 KB) - added by AlfonZ 6 years ago.
Regression test
8954-test.2.patch (3.8 KB) - added by AlfonZ 6 years ago.
Regression test. If property josm.test.data is not set, use ./test/data.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by skyper

Description: modified (diff)

Translate report

Changed 6 years ago by skyper

Attachment: broken_preset.xml added

preset

comment:2 Changed 6 years ago by skyper

Cc: Don-vip added
Component: unspecifiedCore
Keywords: preset check added

Can reproduce with openjdk-6 and 7.

Changed 6 years ago by AlfonZ

Attachment: 8954.patch added

comment:3 Changed 6 years ago by AlfonZ

Caused by r6114.
Happens only if checkboxes are the last thing in the (whole) preset.

comment:4 Changed 6 years ago by skyper

Description: modified (diff)
Summary: In Vorlagen werden Checkboxen nicht dargestellt[Patch] Checkboxes not displayed in preset (In Vorlagen werden Checkboxen nicht dargestellt)

Translation part two

comment:5 Changed 6 years ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

comment:6 Changed 6 years ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 6139/josm:

fix #8954 - checkboxes not displayed in presets if they are the last file element (regression from r6114, patch by AlfonZ)

Changed 6 years ago by AlfonZ

Attachment: 8954-test.patch added

Regression test

comment:7 Changed 6 years ago by AlfonZ

I've attached unit test that tests this. Feedback's welcome.

comment:8 Changed 6 years ago by Don-vip

Thanks, test patches are always welcome :)
Although the test works fin with ant, it does not when running it directly from Eclipse:

java.lang.AssertionError: Property josm.test.data is not set
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.openstreetmap.josm.gui.tagging.TaggingPresetReaderTest.setUpClass(TaggingPresetReaderTest.java:37)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

Changed 6 years ago by AlfonZ

Attachment: 8954-test.2.patch added

Regression test. If property josm.test.data is not set, use ./test/data.

comment:9 Changed 6 years ago by AlfonZ

It reads file test/data/regress/8954/preset.xml. I introduced new system property josm.test.data (set in build.xml to test/data) to avoid using current working directory.
As other tests currently need properly set CWD anyways, I've changed it to use it as well.

comment:10 Changed 6 years ago by Don-vip

In 6144/josm:

see #8954 - new tagging preset reader regression test (patch by AlfonZ)

comment:11 Changed 6 years ago by Don-vip

thanks !

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.