[Patch] Checkboxes not displayed in preset (In Vorlagen werden Checkboxen nicht dargestellt)

[Zecke]

What steps will reproduce the problem?

1. Vorlage mit Checkbox verwenden (JOSM 6115 und 6129)
2. Checkbox wird nicht dargestellt, Comboboxen, Textfelder gehen

1. Use preset with checkbox (JOSM 6115 and 6129)
2. Checkbox is not displayed, combos and text work.

Detaillierte Beschreibung (detailed description in German):
​http://forum.openstreetmap.org/viewtopic.php?id=22163

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-08-07 01:35:24
Last Changed Author: Don-vip
Revision: 6115
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-08-07 00:04:24 +0200 (Wed, 07 Aug 2013)
Last Changed Rev: 6115

Identification: JOSM/1.5 (6115 de) Windows 7 64-Bit
Memory Usage: 220 MB / 1816 MB (64 MB allocated, but free)
Java version: 1.7.0_21, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Xverify:remote, -Djnlpx.home=C:\Program Files\Java\jre7\bin, -Djnlpx.origFilenameArg=C:\Users\cg\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\21\73111055-564844fd, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Xbootclasspath/a:C:\Program Files\Java\jre7\lib\javaws.jar;C:\Program Files\Java\jre7\lib\deploy.jar;C:\Program Files\Java\jre7\lib\plugin.jar, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=49477, -Djnlp.application.href=http://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=C:\Program Files\Java\jre7\bin\javaw.exe, -Djnlpx.vmargs=-Djava.util.Arrays.useLegacyMergeSort=true -Djnlp.application.href=http://josm.openstreetmap.de/download/josm.jnlp]
Dataset consistency test: No problems found

Plugin: DirectUpload (29778)
Plugin: PicLayer (29809)
Plugin: editgpx (29596)

[skyper]

Translate report

[skyper]

preset

[skyper]

Can reproduce with openjdk-6 and 7.

[AlfonZ]

Caused by r6114.
Happens only if checkboxes are the last thing in the (whole) preset.

[skyper]

Translation part two

[Don-vip]

In 6139/josm:

fix #8954 - checkboxes not displayed in presets if they are the last file element (regression from r6114, patch by AlfonZ)

[AlfonZ]

Regression test

[AlfonZ]

I've attached unit test that tests this. Feedback's welcome.

[Don-vip]

Thanks, test patches are always welcome :)
Although the test works fin with ant, it does not when running it directly from Eclipse:

java.lang.AssertionError: Property josm.test.data is not set
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.openstreetmap.josm.gui.tagging.TaggingPresetReaderTest.setUpClass(TaggingPresetReaderTest.java:37)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

[AlfonZ]

Regression test. If property josm.test.data is not set, use ./test/data.

[AlfonZ]

It reads file test/data/regress/8954/preset.xml. I introduced new system property josm.test.data (set in build.xml to test/data) to avoid using current working directory.
As other tests currently need properly set CWD anyways, I've changed it to use it as well.

[Don-vip]

In 6144/josm:

see #8954 - new tagging preset reader regression test (patch by AlfonZ)

[Don-vip]

thanks !