Installing a plugin that requires a newer JOSM version results in a incomplete download because warning dialog is hidden by progress bar

[Zverikk]

Please try doing it yourself. The plugin is very important, and failure to install in the latest tested version is unacceptable.

1. Open plugin preferences, find notes, check the box against it, press OK.
2. "Downloading plugin notes" progress bar appears, but does not progress.
3. Find out there is a dialog behind it: "JOSM version 6070 is required for notes plugin" with two options: "download" and "skip".
4. Notice how you can't press any of the buttons because the dialog is blocked by "downloading" panel.
5. The notice how pressing "cancel" on said panel does nothing.
6. Close the panel with "X" window button, then press "download plugin" button which is now active.
7. The last line in the console is "Incorrect jar file '/home/zverik/.josm/plugins/notes.jar.new'"
8. Restart JOSM.
9. Look at a dialog "Cannot load notes plugin, because its main class is not found" and dismiss it.

JOSM 6060 / archlinux / Java 1.7.0_01 64-bit

[ToeBee]

First of all, the unclickable dialog seems like a bug in JOSM core, not the plugin being installed.

I guess the notes plugin could be modified to not require 6070 but then things will break for anyone using oauth on 6060. I would kind of like to push people to 6070 for this reason. Wonder when the next -tested release will be? I think getting the oauth changes into tested should be fairly high on the to-do list.

[Don-vip]

Replying to Zverikk:

The plugin is very important, and failure to install in the latest tested version is unacceptable.

This is a new feature that required some changes in core, so it is perfectly acceptable to require JOSM latest version. It is not technically possible to use notes with current tested, see r6066 and #8875.

2. "Downloading plugin notes" progress bar appears, but does not progress.
3. Find out there is a dialog behind it: "JOSM version 6070 is required for notes plugin" with two options: "download" and "skip".
4. Notice how you can't press any of the buttons because the dialog is blocked by "downloading" panel.
5. The notice how pressing "cancel" on said panel does nothing.

I thought this bug had been fixed in r6048, I will look into it.

Replying to ToeBee:

First of all, the unclickable dialog seems like a bug in JOSM core, not the plugin being installed.

Exactly, moving this ticket to core.

I guess the notes plugin could be modified to not require 6070 but then things will break for anyone using oauth on 6060. I would kind of like to push people to 6070 for this reason. Wonder when the next -tested release will be? I think getting the oauth changes into tested should be fairly high on the to-do list.

Don't waste your time on this, it would only make the things worse. See DevelopersGuide/Schedule to track the development state of JOSM. Next tested is planned 5th of August.

[Don-vip]

I cannot reproduce with r6060 on Windows, the dialog is in front of progress window, not behind (that's effectively what I fixed in r6048).

Is there someone else able to reproduce it ? It's strange.

[ToeBee]

Yes, I can reproduce it. Running linux mint with the cinnamon desktop and java 6.

[Don-vip]

Not reproduced neither on Ubuntu:

Identification: JOSM/1.5 (6060 en) Linux Ubuntu 13.04
Memory Usage: 60 MB / 423 MB (16 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK Client VM
VM arguments: [-Djava.net.useSystemProxies=true]

[Don-vip]

Can you check both of you if it's related to Java version ? (i.e try with a recent one)
Thanks

[Don-vip]

up ?
skyper, have you observed this bug too ?

[skyper]

Replying to Don-vip:

skyper, have you observed this bug too ?

Can reproduce with openjdk-6:

1. download and start r6060 with empty preference dir
2. go to preferences and try to install notes plugin after downloading list

Get the two non-working dialogs with the important one hidden. Download does not work at all.

java version "1.6.0_27"
OpenJDK Runtime Environment (IcedTea6 1.12.6) (6b27-1.12.6-1~deb7u1)
OpenJDK 64-Bit Server VM (build 20.0-b12, mixed mode)

With openjdk-7 the order is right, the dialogs do work and the plugin is downloaded.

java version "1.7.0_25"
OpenJDK Runtime Environment (IcedTea 2.3.10) (7u25-2.3.10-1~deb7u1)
OpenJDK 64-Bit Server VM (build 23.7-b01, mixed mode)

[Don-vip]

ok, I'll try to reproduce with Java 6

[Don-vip]

Works fine with Oracle 6u45...

[Don-vip]

I assume this is a bug of OpenJDK6/very old versions of OpenJDK7.