Modify

Opened 11 years ago

Closed 11 years ago

#8870 closed defect (fixed)

Data layer context menu: Go to OSM wiki page does not always work

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

The summary already says it. I get:

INFO: http://wiki.openstreetmap.org/wiki/En:Key:placement does not exist
INFO: http://wiki.openstreetmap.org/wiki/Key:placement is a mediawiki redirect
INFO: http://wiki.openstreetmap.org/wiki/En:Key:width does not exist
INFO: http://wiki.openstreetmap.org/wiki/Key:width is a mediawiki redirect

but this is working

INFO: http://wiki.openstreetmap.org/wiki/En:Tag:highway=residential does not exist
INFO: browsing to http://wiki.openstreetmap.org/wiki/Tag:highway=residential

All pages open through right click on the info messages in GNOME-Terminal.

Attachments (0)

Change History (8)

comment:1 by Don-vip, 11 years ago

looks like this code doesn't work:

/* redirect pages have different content length, but retrieving a "nonredirect"
 *  page using index.php and the direct-link method gives slightly different
 *  content lengths, so we have to be fuzzy.. (this is UGLY, recode if u know better)
 */
if (Math.abs(conn.getContentLength() - osize) > 200) {
    Main.info("{0} is a mediawiki redirect", u);
    conn.disconnect();
}
Last edited 11 years ago by Don-vip (previous) (diff)

comment:2 by Don-vip, 11 years ago

Owner: changed from team to skyper
Status: newneedinfo

It works now ?? Maybe a problem on osm wiki side ? Can you check if it works with you too ?

in reply to:  2 comment:3 by skyper, 11 years ago

Replying to Don-vip:

It works now ?? Maybe a problem on osm wiki side ? Can you check if it works with you too ?

No, it does not (r6075).

EDT: width works now

INFO: http://wiki.openstreetmap.org/wiki/En:Tag:placement=left_of%3A1 does not exist
INFO: http://wiki.openstreetmap.org/wiki/Tag:placement=left_of%3A1 does not exist
INFO: http://wiki.openstreetmap.org/wiki/En:Key:placement does not exist
INFO: http://wiki.openstreetmap.org/wiki/Key:placement is a mediawiki redirect
INFO: http://wiki.openstreetmap.org/wiki/En:Map_Features does not exist
INFO: http://wiki.openstreetmap.org/wiki/Map_Features is a mediawiki redirect

Is there a problem with the command line option --language ?

I also noticed that I am send to Map_Features if there is no page in locale language. Think it would be better to use English as fallback instead of directly leading to Map_Features.

Last edited 11 years ago by skyper (previous) (diff)

comment:4 by skyper, 11 years ago

Owner: changed from skyper to team
Status: needinfonew

comment:5 by Don-vip, 11 years ago

It works with placement right now:

INFO: http://wiki.openstreetmap.org/wiki/En_GB:Tag:placement=left_of%3A1 does not exist
INFO: http://wiki.openstreetmap.org/wiki/Tag:placement=left_of%3A1 does not exist
INFO: http://wiki.openstreetmap.org/wiki/En_GB:Key:placement does not exist
INFO: browsing to http://wiki.openstreetmap.org/wiki/Key:placement

Not easy to fix this bug if I can't reproduce it each time :(

comment:6 by skyper, 11 years ago

Does not work for me ATM:

INFO: http://wiki.openstreetmap.org/wiki/En:Tag:placement=left_of%3A2 does not exist
INFO: http://wiki.openstreetmap.org/wiki/Tag:placement=left_of%3A2 does not exist
INFO: http://wiki.openstreetmap.org/wiki/En:Key:placement does not exist
INFO: http://wiki.openstreetmap.org/wiki/Key:placement is a mediawiki redirect
INFO: http://wiki.openstreetmap.org/wiki/En:Map_Features does not exist
INFO: browsing to http://wiki.openstreetmap.org/wiki/Map_Features

I even did turn of noscript.

Last thing that could make a difference is that I am already logged in one the wiki using https.

in reply to:  6 comment:7 by skyper, 11 years ago

Replying to skyper:

Does not work for me ATM:

INFO: http://wiki.openstreetmap.org/wiki/En:Tag:placement=left_of%3A2 does not exist
INFO: http://wiki.openstreetmap.org/wiki/Tag:placement=left_of%3A2 does not exist
INFO: http://wiki.openstreetmap.org/wiki/En:Key:placement does not exist
INFO: http://wiki.openstreetmap.org/wiki/Key:placement is a mediawiki redirect
INFO: http://wiki.openstreetmap.org/wiki/En:Map_Features does not exist
INFO: browsing to http://wiki.openstreetmap.org/wiki/Map_Features

I even did turn of noscript.

Last thing that could make a difference is that I am already logged in one the wiki using https.

Checked without difference. Do not have anymore ideas for now.

comment:8 by Don-vip, 11 years ago

Resolution: fixed
Status: newclosed

In 6109/josm:

fix #8870 - Data layer context menu: Go to OSM wiki page does not always work

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.