Modify

Opened 9 years ago

Closed 9 years ago

#8866 closed defect (fixed)

Exception after deleting an empty relation

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. wanted to exchange a multipolygon of houses with single houses and therefore deleted relation
  2. deleted inner and then outer
  3. usually there shouldn't be anything left over, but this time there was an empty relation
  4. aborted saving and deleted the empty relation

What is the expected result?
empty relation is deleted without a problem

What happens instead?
an exception

Please provide any additional information below. Attach a screenshot if
possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-07-10 01:34:22
Last Changed Author: stoecker
Revision: 6060
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-07-08 22:13:24 +0200 (Mon, 08 Jul 2013)
Last Changed Rev: 6060

Identification: JOSM/1.5 (6060 de) Linux openSUSE 12.3 (x86_64)
Memory Usage: 166 MB / 1768 MB (33 MB allocated, but free)
Java version: 1.7.0_21, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Xbootclasspath/a:/usr/share/icedtea-web/netx.jar:/usr/share/java/js.jar, -Xms8m, -Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws]
Dataset consistency test: No problems found

Plugin: FixAddresses (29661)
Plugin: HouseNumberTaggingTool (29487)
Plugin: geochat (29592)
Plugin: merge-overlap (29645)
Plugin: terracer (29623)
Plugin: turnrestrictions (29435)
Plugin: waypoint_search (29435)
Plugin: wikipedia (29523)

java.util.NoSuchElementException
	at java.util.Collections$EmptyIterator.next(Collections.java:3006)
	at org.openstreetmap.josm.data.validation.tests.RelationChecker.isFixable(RelationChecker.java:232)
	at org.openstreetmap.josm.data.validation.TestError.isFixable(TestError.java:235)
	at org.openstreetmap.josm.gui.dialogs.ValidatorDialog.setSelection(ValidatorDialog.java:378)
	at org.openstreetmap.josm.gui.dialogs.ValidatorDialog.access$700(ValidatorDialog.java:65)
	at org.openstreetmap.josm.gui.dialogs.ValidatorDialog$SelectionWatch.valueChanged(ValidatorDialog.java:510)
	at javax.swing.JTree.fireValueChanged(JTree.java:2919)
	at javax.swing.JTree$TreeSelectionRedirector.valueChanged(JTree.java:3378)
	at javax.swing.tree.DefaultTreeSelectionModel.fireValueChanged(DefaultTreeSelectionModel.java:634)
	at javax.swing.tree.DefaultTreeSelectionModel.notifyPathChange(DefaultTreeSelectionModel.java:1092)
	at javax.swing.tree.DefaultTreeSelectionModel.addSelectionPaths(DefaultTreeSelectionModel.java:411)
	at javax.swing.tree.DefaultTreeSelectionModel.addSelectionPath(DefaultTreeSelectionModel.java:309)
	at javax.swing.JTree.addSelectionPath(JTree.java:1738)
	at javax.swing.JTree.setExpandedState(JTree.java:3596)
	at javax.swing.JTree.collapsePath(JTree.java:2229)
	at javax.swing.plaf.basic.BasicTreeUI.toggleExpandState(BasicTreeUI.java:2276)
	at javax.swing.plaf.basic.BasicTreeUI.handleExpandControlClick(BasicTreeUI.java:2252)
	at javax.swing.plaf.basic.BasicTreeUI.checkForClickInExpandControl(BasicTreeUI.java:2210)
	at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection(BasicTreeUI.java:3579)
	at javax.swing.plaf.basic.BasicTreeUI$Handler.mousePressed(BasicTreeUI.java:3527)
	at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:279)
	at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:279)
	at java.awt.Component.processMouseEvent(Component.java:6502)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3312)
	at java.awt.Component.processEvent(Component.java:6270)
	at java.awt.Container.processEvent(Container.java:2229)
	at java.awt.Component.dispatchEventImpl(Component.java:4861)
	at java.awt.Container.dispatchEventImpl(Container.java:2287)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4489)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
	at java.awt.Container.dispatchEventImpl(Container.java:2273)
	at java.awt.Window.dispatchEventImpl(Window.java:2719)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:729)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:688)
	at java.awt.EventQueue$3.run(EventQueue.java:686)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.awt.EventQueue$4.run(EventQueue.java:702)
	at java.awt.EventQueue$4.run(EventQueue.java:700)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:699)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

Attachments (0)

Change History (4)

comment:1 Changed 9 years ago by skyper

Could you please tell us the id of the relation and/or attach s small example .osm file to reproduce ?

Thanks

comment:2 Changed 9 years ago by Don-vip

Component: CoreCore validator

Problem looks similar to #8822

comment:3 Changed 9 years ago by gorgonz@…

i'm not exactly here, but i guess, that it was in changeset http://www.openstreetmap.org/browse/changeset/16905015 and there are 3 candidates. hmm, think it was 93462.

comment:4 Changed 9 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6062/josm:

fix #8866 - NoSuchElementException after deleting an empty relation

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.