Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8829 closed defect (fixed)

relation editor broken badly in r6037

Reported by: rickmastfan67 Owned by: team
Priority: blocker Milestone:
Component: Core Version: latest
Keywords: Cc: akks

Description

I recently downloaded the new "latest" version of JOSM, which is r6037. So, I go ahead and start doing my normal editing and have to split up a relation since I needed to twin a highway.

So, I go into the relation to add in the new parts of the highway. Tag the new and old ways as forward and then hit the "OK" button to save my work so I could continue on. However, JOSM then completely freezes up. All the buttons are now dead and I've lost that work. Had to go into Windows Task Manager and force crash Java to kill JOSM. Not good. I then downgraded back to r6034 and attempted to do the same thing and it works correctly in it. Because of this, I've marked this as a blocker.

Quick and easy steps to reproduce this:

  1. Download the following way: 95911113 (make sure the first two boxes are checkmarked)
  2. Select any of the relations that downloaded as part of the way.
  3. Pop into the relation editor and change the "role" for the way to anything and hit "OK".

What happens:
JOSM goes into lockdown crash mode with no error message (nothing in the console either) forcing you to crash Java to close JOSM.

What should happen:
The relation should be edited and the role should be applied to the way. (and JOSM shouldn't crash of course)

I'm guessing that the changes in [6036] broke this.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-06-28 01:34:43
Last Changed Author: akks
Revision: 6037
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-06-27 20:26:18 +0200 (Thu, 27 Jun 2013)
Last Changed Rev: 6037

Identification: JOSM/1.5 (6037 en) Windows 7 64-Bit
Memory Usage: 154 MB / 2730 MB (75 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx3072M]

Plugin: ImageryCache (29690)
Plugin: OpeningHoursEditor (29435)
Plugin: buildings_tools (29596)
Plugin: mapdust (29525)
Plugin: measurement (29625)
Plugin: mirrored_download (29643)
Plugin: openstreetbugs (29435)
Plugin: osmarender (29639)
Plugin: reverter (29663)
Plugin: turnrestrictions (29435)
Plugin: undelete (29555)
Plugin: utilsplugin2 (29672)

Attachments (0)

Change History (10)

comment:1 Changed 6 years ago by Don-vip

Cc: akks added

comment:2 Changed 6 years ago by akks

My fault, it is r6036. Fixing (or reverting if can not).

comment:3 Changed 6 years ago by akks

Resolution: fixed
Status: newclosed

In 6038/josm:

fix #8829: relation was often hanging JOSM after 6036 + better highlighting

comment:4 Changed 6 years ago by akks

I hope this will help. Doing highlighting when operation was not finished was blocking the event queue (there was also hanging sometimes after downloading relation members).

Here is the custom build for testing:
https://dl.dropboxusercontent.com/u/63393258/josm-custom.jar

@stoecker: please, can we automate creating testing jars after each commit? I guess not all of our bug reporters have compileable sources.
Maybe we should also repalce "latest" now to avoid more problems with blocking :)

comment:5 Changed 6 years ago by Don-vip

Thanks akks for your reactivity ;)

comment:6 Changed 6 years ago by rickmastfan67

Just tested with [6041] and it's working properly again. Thanks for the fix. :)

comment:7 Changed 6 years ago by skyper

EDT: Sorry, need to wake up first

comment:8 Changed 6 years ago by stoecker

Max one day delay should be acceptable. Ne need to increase the frequency of latest.

comment:9 Changed 6 years ago by akks

One "latest" per day is of course enough, but for.faster debugging it would be useful to have all revisions in dowload folders, updated after every commit. The other advantage is the instant detection of "broken commits" with uncompilable code.

comment:10 in reply to:  9 Changed 6 years ago by skyper

Replying to akks:

Replying to stoecker:

Max one day delay should be acceptable. Ne need to increase the frequency of latest.

+1

One "latest" per day is of course enough, but for.faster debugging it would be useful to have all revisions in dowload folders, updated after every commit. The other advantage is the instant detection of "broken commits" with uncompilable code.

Do you know Cobra's Script for linux. Maybe we can develop a similar script for other OS and offer it with a simple instruction that tester could easily compile a version for testing by themselve.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.