When an image loading "times out", use a simple error message in the console. (imagerycache)

[rickmastfan67]

I've been noticing this for awhile while using the imagerycache plugin and finally thought about making a ticket about it.

Whenever an image is trying to be loaded for the background in JOSM and it times out, an ugly plugin crash is shown in the console. Before I started using this plugin when this happened, in the JOSM console, a simple error message was shown:
Failed loading http://ecn.t1.tiles.virtualearth.net/tiles/a0320011102033321020.jpeg?g=1438: connect timed out

Instead, we get this every time just one image fails to load making it sometimes hard to spot true bugs that are mentioned in there that don't pop up an error box inside of JOSM itself.

Error: Tile 305748181746 can not be loaded from http://ecn.t1.tiles.virtualearth.net/tiles/a0320011102033321020.jpeg?g=1438
java.net.SocketTimeoutException: connect timed out
        at sun.reflect.GeneratedConstructorAccessor23.newInstance(Unknown Source)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
        at java.lang.reflect.Constructor.newInstance(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection$6.run(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection$6.run(Unknown Source)
        at java.security.AccessController.doPrivileged(Native Method)
        at sun.net.www.protocol.http.HttpURLConnection.getChainedException(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection.getInputStream(Unknown Source)
        at java.net.HttpURLConnection.getResponseCode(Unknown Source)
        at org.openstreetmap.josm.plugins.imagerycache.OsmDBTilesLoader$DatabaseLoadJob.loadOrUpdateTileFromServer(OsmDBTilesLoader.java:204)
        at org.openstreetmap.josm.plugins.imagerycache.OsmDBTilesLoader$DatabaseLoadJob.access$000(OsmDBTilesLoader.java:52)
        at org.openstreetmap.josm.plugins.imagerycache.OsmDBTilesLoader$DatabaseLoadJob$1.run(OsmDBTilesLoader.java:90)
        at org.openstreetmap.gui.jmapviewer.JobDispatcher$JobThread.executeJobs(JobDispatcher.java:168)
        at org.openstreetmap.gui.jmapviewer.JobDispatcher$JobThread.run(JobDispatcher.java:135)
Caused by: java.net.SocketTimeoutException: connect timed out
        at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
        at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
        at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
        at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
        at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
        at java.net.PlainSocketImpl.connect(Unknown Source)
        at java.net.SocksSocketImpl.connect(Unknown Source)
        at java.net.Socket.connect(Unknown Source)
        at sun.net.NetworkClient.doConnect(Unknown Source)
        at sun.net.www.http.HttpClient.openServer(Unknown Source)
        at sun.net.www.http.HttpClient.openServer(Unknown Source)
        at sun.net.www.http.HttpClient.<init>(Unknown Source)
        at sun.net.www.http.HttpClient.New(Unknown Source)
        at sun.net.www.http.HttpClient.New(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection.plainConnect(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection.connect(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection.getInputStream(Unknown Source)
        at sun.net.www.protocol.http.HttpURLConnection.getHeaderField(Unknown Source)
        at org.openstreetmap.josm.plugins.imagerycache.OsmDBTilesLoader$DatabaseLoadJob.loadOrUpdateTileFromServer(OsmDBTilesLoader.java:202)
        ... 4 more

So, if it is possible, can the imagerycache plugin do the "connect timed out" error the same way as JOSM itself?

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-06-20 01:35:32
Last Changed Author: Don-vip
Revision: 6015
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-06-19 09:55:15 +0200 (Wed, 19 Jun 2013)
Last Changed Rev: 6015

Identification: JOSM/1.5 (6015 en) Windows 7 64-Bit
Memory Usage: 154 MB / 2730 MB (71 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx3072M]

Plugin: ImageryCache (29484)
Plugin: OpeningHoursEditor (29435)
Plugin: buildings_tools (29596)
Plugin: mapdust (29525)
Plugin: measurement (29625)
Plugin: mirrored_download (29643)
Plugin: openstreetbugs (29435)
Plugin: osmarender (29639)
Plugin: reverter (29663)
Plugin: turnrestrictions (29435)
Plugin: undelete (29555)
Plugin: utilsplugin2 (29672)

[akks]

Or, I forgot about it. Will put it in to "debug" mode only (at least for SocketTimeoutException)

[Don-vip]

imagerycache plugin has been deprecated in r8772 + [o31575].