Opened 7 years ago

Closed 7 years ago

#8788 closed defect (fixed)

Unnamed nodes are not exported as GPX waypoints

Reported by: brycenesbitt Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc: stoecker


1) Load a few thousand points into a data layer. For example "Open location" with:[amenity=pub]

2) Export to gpx or compressed gpx.

3) Observe your export, silently, has 4260 points.

4) Now delete points until you are at 3000 points.

5) Export again.

6) Observe the gpx file has 4260 points.

Attachments (0)

Change History (12)

comment:1 Changed 7 years ago by Don-vip

Owner: changed from team to brycenesbitt
Status: newneedinfo

Works for me with latest version of JOSM.
Can you please attach your status report, and the file you have at each step ? Thanks.

comment:2 Changed 7 years ago by Don-vip

up ?

comment:3 Changed 7 years ago by brycenesbitt

1) From File->Open Location load[amenity=drinking_water]

and verify it has 34,00 nodes.

2) File->Export to GPS to "test.gpx"
3) grep "wpt lat" /home/bnesbitt/temp/text.gpx | wc

4260 12780 175375

4) Delete half the world's water fountains, and do it again, and you get 4260 points again. Lon? Long? Longitude? Position-X?

It looks like GPX export may be skipping the ones without a "name=" tag?

Separately: It would be nice if the CSV import documented on screen what column names it wants.

comment:4 Changed 7 years ago by brycenesbitt

Verified. The GPX export requires a name=* tag, or it silently leaves out the node.
Instead how about creating an empty <name> in the GPX, or <name>null</name>?

Also: Importing the same gpx file results in a non-editable layer.

comment:5 Changed 7 years ago by brycenesbitt

Repository Root:
Build-Date: 2013-06-05 01:34:49
Last Changed Author: Don-vip
Revision: 5990
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Date: 2013-06-05 00:52:58 +0200 (Wed, 05 Jun 2013)
Last Changed Rev: 5990

Identification: JOSM/1.5 (5990 en) Linux Ubuntu 11.04
Memory Usage: 269 MB / 1328 MB (84 MB allocated, but free)
Java version: 1.6.0_26, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found
Last edited 7 years ago by Don-vip (previous) (diff)

comment:6 Changed 7 years ago by Don-vip

Owner: changed from brycenesbitt to team
Status: needinfonew

ok thanks :)

comment:7 Changed 7 years ago by Don-vip

Cc: stoecker added
Summary: Josm silently truncates GPX export to 4260 points.Unnamed nodes are not exported as GPX waypoints

Looks intentional in r4046.

Dirk, do you think we should save unnamed nodes too ?

comment:8 Changed 7 years ago by brycenesbitt

If intentional, it would help if it said so (4600 or 35000 nodes exported) or (3999 of 4000 nodes exported).
It is too easy not to notice you're missing data if the numbers are close.

comment:9 Changed 7 years ago by stoecker

If I understand that right named nodes are exported as waypoints (and trackpoints), unnamed only as trackpoints. Seems correct to me.

If they aren't exported as trackpoints or waypoints, then something is wrong I'd assume.

comment:10 Changed 7 years ago by brycenesbitt

There are no <trk> or <rte> points in the gpx file from above.
The principle of least surprise I think is to output them all as <wpt>, even if they have no name=tag.

So it is at least an implementation bug, if not a design issue.

comment:11 Changed 7 years ago by stoecker

Probably only line-points are output as trackpoint? In this case we'd need to add output of unnamed single points as unnamed waypoint as well.

comment:12 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6015/josm:

fix #8788 - include unnamed nodes as GPX waypoints during GPX export

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.