Opened 11 years ago
Closed 8 years ago
#8749 closed defect (fixed)
"add to relation" in relation toggle dialog context menu leads to many empty roles.
| Reported by: | skyper | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 16.02 |
| Component: | Core | Version: | latest |
| Keywords: | context menu add relation | Cc: |
Description (last modified by )
We do not have that many relations without member roles.
The new right click option "add elements to relation" makes it too easy to miss setting a role value and does not help in anyway to do so as you need to open the relation editor manually to add the roles.
- please open the relation editor for each relation
use the automatic role suggestions(fixed in r5972)- try to find the proper place to add the new members
Thanks
Attachments (0)
Change History (13)
comment:1 Changed 11 years ago by
comment:3 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:4 follow-up: 5 Changed 11 years ago by
I think the first point does not have to be implemented if we do the third one.
comment:5 Changed 11 years ago by
Replying to Don-vip:
I think the first point does not have to be implemented if we do the third one.
No, it is the major one. Please, keep in mind that you might have to handle incomplete data or unknown relation types. In the end the user should check the result.
Automatic role suggestion might also not work for all objects.
comment:6 follow-up: 7 Changed 10 years ago by
There are use cases where I would not like to have the dialog opened. If we are able to guess a role and insert the new member at the correct position, it is not useful to open the editor, it will just be annoying.
If we cannot guess role or find position, I agree we should open it however.
comment:7 Changed 10 years ago by
Replying to Don-vip:
There are use cases where I would not like to have the dialog opened. If we are able to guess a role and insert the new member at the correct position, it is not useful to open the editor, it will just be annoying.
If we cannot guess role or find position, I agree we should open it however.
Maybe it is possible to make it optional as we still guess and I rather take a look at relations and need one more click or key to press than destroying several relations at once.
comment:8 Changed 8 years ago by
Does the situation improve, if we make AddSelectionToRelations an expert-only action?
comment:9 Changed 8 years ago by
| Milestone: | → 16.01 |
|---|
comment:10 Changed 8 years ago by
| Milestone: | 16.01 → 16.02 |
|---|
In 5972/josm: