Modify

Opened 11 years ago

Closed 9 years ago

#8749 closed defect (fixed)

"add to relation" in relation toggle dialog context menu leads to many empty roles.

Reported by: skyper Owned by: team
Priority: normal Milestone: 16.02
Component: Core Version: latest
Keywords: context menu add relation Cc:

Description (last modified by Don-vip)

We do not have that many relations without member roles.

The new right click option "add elements to relation" makes it too easy to miss setting a role value and does not help in anyway to do so as you need to open the relation editor manually to add the roles.

  • please open the relation editor for each relation
  • use the automatic role suggestions (fixed in r5972)
  • try to find the proper place to add the new members

Thanks

Attachments (0)

Change History (13)

comment:1 by Don-vip, 11 years ago

In 5972/josm:

see #8749 - use the automatic role suggestions when adding selection to a relation from context menu

comment:3 by Don-vip, 11 years ago

Description: modified (diff)

comment:4 by Don-vip, 11 years ago

I think the first point does not have to be implemented if we do the third one.

in reply to:  4 comment:5 by skyper, 11 years ago

Replying to Don-vip:

I think the first point does not have to be implemented if we do the third one.

No, it is the major one. Please, keep in mind that you might have to handle incomplete data or unknown relation types. In the end the user should check the result.

Automatic role suggestion might also not work for all objects.

comment:6 by Don-vip, 11 years ago

There are use cases where I would not like to have the dialog opened. If we are able to guess a role and insert the new member at the correct position, it is not useful to open the editor, it will just be annoying.

If we cannot guess role or find position, I agree we should open it however.

in reply to:  6 comment:7 by skyper, 11 years ago

Replying to Don-vip:

There are use cases where I would not like to have the dialog opened. If we are able to guess a role and insert the new member at the correct position, it is not useful to open the editor, it will just be annoying.

If we cannot guess role or find position, I agree we should open it however.

Maybe it is possible to make it optional as we still guess and I rather take a look at relations and need one more click or key to press than destroying several relations at once.

comment:8 by simon04, 9 years ago

Does the situation improve, if we make AddSelectionToRelations an expert-only action?

comment:9 by simon04, 9 years ago

Milestone: 16.01

comment:10 by simon04, 9 years ago

Milestone: 16.0116.02

comment:11 by simon04, 9 years ago

In 9365/josm:

see #8749 - Make "Add selection to relation" an expert action

comment:12 by simon04, 9 years ago

In 9366/josm:

see #8749 - Show a notification after performing "Add selection to relation"

comment:13 by Don-vip, 9 years ago

Can this ticket be closed?

comment:14 by Don-vip, 9 years ago

Resolution: fixed
Status: newclosed

I think yes :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.