DataIntegrityProblemException when undoing parallel way creation

[kr12]

What steps will reproduce the problem?

1. <osm version='0.6' upload='true' generator='JOSM'>
     <bounds minlat='32.1362283' minlon='73.903141' maxlat='32.1424786' maxlon='73.9117241' origin='CGImap 0.1.0' />
     <bounds minlat='32.1362283' minlon='73.903141' maxlat='32.1424786' maxlon='73.9117241' origin='OpenStreetMap server' />
     <node id='-12132' action='modify' visible='true' lat='31.14198833358746' lon='72.5021304221588' />
     <node id='-12090' action='modify' visible='true' lat='31.14463930260823' lon='72.49818862264976' />
     <node id='-12030' action='modify' visible='true' lat='31.14198833358746' lon='72.5021304221588' />
     <way id='-12176' action='modify' visible='true'>
       <nd ref='-12030' />
       <nd ref='-12132' />
       <nd ref='-12090' />
       <nd ref='-12132' />
       <nd ref='-12030' />
     </way>
   </osm>
   

2. try create parallel with plugin
3. ctrl-z

JOSM must clean such data automatically. Anyway ctrl-z must work.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-04-22 01:34:49
Last Changed Author: stoecker
Revision: 5899
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-04-21 16:34:38 +0200 (Sun, 21 Apr 2013)
Last Changed Rev: 5899

Identification: JOSM/1.5 (5899 en) Windows 7 64-Bit
Memory Usage: 1006 MB / 1006 MB (331 MB allocated, but free)
Java version: 1.7.0_17, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-XX:+UseConcMarkSweepGC, -XX:+DisableExplicitGC, -XX:+UseAdaptiveGCBoundary, -XX:MaxGCPauseMillis=500, -XX:-UseGCOverheadLimit, -XX:SurvivorRatio=12, -Xnoclassgc, -XX:UseSSE=3, -Xincgc, -Xmx1G, -Xms1G]

Dataset consistency test:
[COMPLETE WITHOUT COORDINATES] {Node id=-10252 version=0 MV } is not incomplete but has null coordinates
[COMPLETE WITHOUT COORDINATES] {Node id=-10095 version=0 MV } is not incomplete but has null coordinates
[COMPLETE WITHOUT COORDINATES] {Node id=-10253 version=0 MV } is not incomplete but has null coordinates
[COMPLETE WITHOUT COORDINATES] {Node id=-10260 version=0 MV } is not incomplete but has null coordinates
[COMPLETE WITHOUT COORDINATES] {Node id=-10103 version=0 MV } is not incomplete but has null coordinates
[COMPLETE WITHOUT COORDINATES] {Node id=-10096 version=0 MV } is not incomplete but has null coordinates


Plugin: alignways (29435)

org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Complete node with null coordinates: {Node id=-10261 version=0 MV }
	at org.openstreetmap.josm.data.osm.Node.setDataset(Node.java:191)
	at org.openstreetmap.josm.data.osm.DataSet.removePrimitive(DataSet.java:396)
	at org.openstreetmap.josm.command.AddCommand.undoCommand(AddCommand.java:56)
	at org.openstreetmap.josm.command.SequenceCommand.undoCommands(SequenceCommand.java:76)
	at org.openstreetmap.josm.command.SequenceCommand.undoCommand(SequenceCommand.java:81)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:80)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:66)
	at org.openstreetmap.josm.actions.UndoAction.actionPerformed(UndoAction.java:35)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$200(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[Don-vip]

Your .osm file is corrupted, how did you produce it ?

[kr12]

This is valid XML. This data may appears in many ways. And I create it in JOSM.
Anyway the ctrl-z have bug. It must undo changes, even if previous command brings exception. But in this ticked ctrl-z cause exception (№2 worked wrong, but if press delete I can delete new way without problems)

[kr12]

also as I mentioned "JOSM must clean such data automatically." if it is really corrupted

[Don-vip]

ok sorry I read the XML too fast

[Don-vip]

In 5980/josm:

see #8631 - Sanity checks in geometry functions dealing with coordinates + javadoc

[Don-vip]

In 5981/josm:

fix #8631 - Make ParallelWays more robust to self-intersecting ways