Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8601 closed defect (fixed)

Cancel-button doesn't cancel

Reported by: malenki Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description (last modified by malenki)

Since recently the API was a little fragile JOSM several times got stuck while asking the API for the history or for data. Clicking the cancel-button didn't cancel the query in question. It didn't seem to influence JOSM in no way.

Earlier I experienced the same behavior on JOSM when I wanted to cancel querying for the history of an object with a lot of versions.

Expected result clicking cancel: JOSM stops instantly doing what it is doing.

Edit: you can try the cancel button while loading the history of this relation with 1379 versions so far: http://www.openstreetmap.org/browse/relation/33232

Attachments (0)

Change History (7)

comment:1 Changed 7 years ago by malenki

Description: modified (diff)

comment:2 Changed 7 years ago by akks

Resolution: fixed
Status: newclosed

In 5856/josm:

fix #8601: Cancel-button doesn't cancel while downloading history

comment:3 Changed 7 years ago by akks

I hope this will work. When running OsmApi.getOsmApi().cancel() no connection was stopped (activeConnection was null for it).

The same potentially non-working cancel method is used by relation dialog:
ChildRelationBrowser.java lines 303, 454
ParentRelationLoadingTask.java line 123
RelationTree.java line 123

comment:4 Changed 7 years ago by stoecker

This issue exists in multiple places - Yes. You will find more related tickets, when searching.

Do you think of removing the comment and debug text?

comment:5 Changed 7 years ago by akks

If the fix is correct, I'll remove the comments it :)
(maybe when fixing next ticket)

comment:6 Changed 7 years ago by malenki

Thanks for the quick fix. (I should have ticketed this one earlier since it nagged me quite often)

comment:7 Changed 7 years ago by akks

In 5859/josm:

see #8274, #8601 : cancel now works while parsing OSM

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.