#8601 closed defect (fixed)
Cancel-button doesn't cancel
Reported by: | malenki | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | Cc: |
Description (last modified by )
Since recently the API was a little fragile JOSM several times got stuck while asking the API for the history or for data. Clicking the cancel-button didn't cancel the query in question. It didn't seem to influence JOSM in no way.
Earlier I experienced the same behavior on JOSM when I wanted to cancel querying for the history of an object with a lot of versions.
Expected result clicking cancel: JOSM stops instantly doing what it is doing.
Edit: you can try the cancel button while loading the history of this relation with 1379 versions so far: http://www.openstreetmap.org/browse/relation/33232
Attachments (0)
Change History (7)
comment:1 by , 11 years ago
Description: | modified (diff) |
---|
comment:2 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 by , 11 years ago
I hope this will work. When running OsmApi.getOsmApi().cancel()
no connection was stopped (activeConnection was null for it).
The same potentially non-working cancel method is used by relation dialog:
ChildRelationBrowser.java lines 303, 454
ParentRelationLoadingTask.java line 123
RelationTree.java line 123
comment:4 by , 11 years ago
This issue exists in multiple places - Yes. You will find more related tickets, when searching.
Do you think of removing the comment and debug text?
comment:5 by , 11 years ago
If the fix is correct, I'll remove the comments it :)
(maybe when fixing next ticket)
comment:6 by , 11 years ago
Thanks for the quick fix. (I should have ticketed this one earlier since it nagged me quite often)
In 5856/josm: