Modify

Opened 11 years ago

Closed 5 years ago

#8595 closed defect (fixed)

[Patch] Split Object does not work although selection is clear (2 nodes and one way)

Reported by: anonymous Owned by: team
Priority: major Milestone:
Component: Plugin utilsplugin2 Version:
Keywords: Cc:

Description

Split Object can split an object with selecting two nodes. If the way is not clear, there is an requester that i have to select the way, too.
But this does not work since a few weeks (using latest via webstart). In this case a SplitWay works, but not splitObject.

For example select Node 1014265155 and 1014265182. SplitObject can not work, because it could split way 208893067 or 87223854, but selecting one way does solve this problem.

Attachments (1)

8595.diff (760 bytes ) - added by mdk 9 years ago.
patch

Download all attachments as: .zip

Change History (15)

comment:1 by mdk, 10 years ago

I have the same problem. Perhaps this clarify the problem:
If you select two nodes, JOSM can easily find out the ways both nodes belongs to (if exists). If there is more than one way, you can normally clarify this by additionally selecting one of the ways. Most functions in JOSM, which needs a way and nodes of this way, has now enough information to work (like "split way"). But "split object" still shows the error "There is more than one way using the nodes you selected. Please select the way also.". But that is exactly what I have done!

Last edited 10 years ago by mdk (previous) (diff)

comment:2 by mailjosm@…, 9 years ago

This is really annoying. A fix should be not so difficult (if familiar with the codebase :-)

by mdk, 9 years ago

Attachment: 8595.diff added

patch

comment:3 by mdk, 9 years ago

Summary: Split Object does not work, if way are not clear[Patch] Split Object does not work when selection is clear (2 nodes and one way)

The attached patch fixes this problem. But I'm not sure if there is a better way for this.

comment:4 by mdk, 9 years ago

If we don't want to use the same code for selecting way and nodes for "split way" and "split object", we can simply fix this problem with the attached patch.

Or is there any other reason not integrating this patch?

comment:5 by anonymous, 8 years ago

ping... :-)

comment:6 by stoecker, 8 years ago

Milestone: 16.02

comment:7 by Don-vip, 8 years ago

Milestone: 16.02

milestones are for core tickets :)

comment:8 by stoecker, 8 years ago

Ooops.

comment:9 by Stereo, 7 years ago

I hope it's ok for me to ping on this again. It's a bug that's been plaguing us since 2013, we've had a patch for almost two years, and there's no clear way forward. I'm not sure what would need to happen now for this to be fixed.

comment:10 by skyper, 7 years ago

Well, did vote but never "cc"-ed.

+1, really annoying.

comment:11 by GerdP, 5 years ago

This problems seems to be fixed. I cannot reproduce it.

comment:12 by GerdP, 5 years ago

Sorry, used P (Split Way) instead of Alt-X. I'll try the patch and if I find no problems I'll commit it.

comment:13 by GerdP, 5 years ago

Fixed with [o34778:34779]
@mdk Thanks for the patch.

comment:14 by GerdP, 5 years ago

Resolution: fixed
Status: newclosed
Summary: [Patch] Split Object does not work when selection is clear (2 nodes and one way)[Patch] Split Object does not work although selection is clear (2 nodes and one way)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.