Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8573 closed defect (fixed)

Full tile info can't be displayed if using imagerycache plugin

Reported by: rickmastfan67 Owned by: akks
Priority: major Milestone:
Component: Plugin imagerycache Version: latest
Keywords: Cc:

Description (last modified by rickmastfan67)

Just happened to notice this when I tried to right click on the Bing Imagery layer inside of JOSM to find out the date of the imagery.

If you have the imagerycache plugin installed, whenever you right click and select "Show Tile Info", you only get part of the info for that tile.

For example, here's the info you would normally get on a random tile using Bing Imagery without the plugin installed:

Tile 18/61590/106172@Bing Aerial Maps
capture-date: 5/15/2011-5/26/2011
etag: "775"

With the imagerycache plugin installed and running, you only get the top line. The "capture-date" & "etag" info isn't shown. :(

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-04-04 01:34:37
Last Changed Author: Don-vip
Revision: 5824
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-04-03 22:34:42 +0200 (Wed, 03 Apr 2013)
Last Changed Rev: 5824

Identification: JOSM/1.5 (5824 en) Windows 7
Memory Usage: 154 MB / 2730 MB (80 MB allocated, but free)
Java version: 1.7.0_15, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7

Plugin: ImageryCache (29368)
Plugin: OpeningHoursEditor (29210)
Plugin: buildings_tools (29210)
Plugin: mapdust (29210)
Plugin: measurement (29344)
Plugin: mirrored_download (29210)
Plugin: openstreetbugs (29373)
Plugin: osmarender (29210)
Plugin: reverter (29359)
Plugin: turnrestrictions (29210)
Plugin: undelete (29210)
Plugin: utilsplugin2 (29392)

Attachments (0)

Change History (9)

comment:1 Changed 6 years ago by rickmastfan67

Description: modified (diff)

comment:2 Changed 6 years ago by akks

Normally, you will get the same description on the tile with ImageryCache (I checked).
Seems that your database is corrupted. The plugin break the database very often. It can happen when running multiple JOSMs, cleaning /tmp in arbitrary time, closing JOSM while loading tiles...

If the info is not shown after deleting C:\Documents and Settings\...\AppData\Local\Temp\JMapViewerTiles_...\...Bing... , then it is possibly another bug.

comment:3 Changed 6 years ago by akks

Oh, sorry, you are right.

If the tile is just loaded from server, info is shown correctly. If it is loaded from database, it is deleted somehow. I am locationg and fixing the problem (it can have bad consequences, not only info-displaying), thank you for report!

comment:4 Changed 6 years ago by rickmastfan67

np man. Looking forward to the fix when it's ready. :)

comment:5 Changed 6 years ago by akks

Nice. I notice I have entirely forgotten to load metadata from database :) It was stored correctly but not loaded.
I am fixing other bug and then committing plugin.

comment:6 Changed 6 years ago by stoecker

P.S. Maybe you can fix the code to be Java 6 compatible as well?

comment:7 Changed 6 years ago by akks

Yes, I'll try. I hope it is not MapDB dependence - it is like black box (with bugs) to me :)

comment:8 Changed 6 years ago by akks

I have commented unnecessary MapDB code to compile on Java 1.6.
Stumbled upon deadlock on starting MapDB fixed on 19 March, updating MapDB to later version...
Oh, next version compiles on Java 6 without changes.

Last edited 6 years ago by akks (previous) (diff)

comment:9 Changed 6 years ago by akks

Resolution: fixed
Status: newclosed

Fixed in [osm29484], I hope.
#8560 leaves open for now.

Changelog:

  • Updated MapDB from GitHub, version 06.04, occasional deadlock on start fixed
  • Java 1.6 compatibilty due to update of MapDB
  • Metadata is loaded from database correctly
  • Code refactoring, iterfaces introduces
  • Stop background database operations on closing (much less errors on shutdown), needs MapDB one-line hack
  • Multiple JOSM instances now store JOSM in multiple files (Mapnik, Mapnik_1, Mapnik_2, etc.) , Mapnik.lock file indicates that the file is currently used
  • DAO object is a singleton now, one file per JVM will be created
  • Cache directory is created if needed

Many thanks for the reports!

Last edited 6 years ago by akks (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain akks.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.