Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8549 closed defect (fixed)

[PATCH] Remove offset server support

Reported by: Zverikk Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: offset server, imagery Cc:

Description

The osmosnimki server has been down for at least a year, and the API was as bad as it gets. I propose to remove all traces of offset server support, because there isn't going to appear any. Especially with the new imagery offset database infrastructure.

Attachments (1)

remove_offset_server.patch (13.9 KB) - added by Zverikk 7 years ago.
A patch to remove all traces of offset server support

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Zverikk

Attachment: remove_offset_server.patch added

A patch to remove all traces of offset server support

comment:1 Changed 7 years ago by akks

I vote for the inclusion of the patch (if we are not in stabilization phase at least).

My comments:

New imagery offset database infrastructure is developed by Zverik and it seems to work
http://wiki.openstreetmap.org/wiki/Imagery_Offset_Database
(but still need testing period, minor updates, some rework before possible future inclusion)

The old offset server is down and sometimes causes exceptions like this:
http://forum.openstreetmap.org/viewtopic.php?pid=323585#p323585

I also propose not to remove useOffsetServer and offsetServerUrl configuration from GUI but disable it permanently. When the new infrastructure will become mature, they could be re-enabled.

Last edited 7 years ago by akks (previous) (diff)

comment:2 Changed 7 years ago by Zverikk

Since the inclusion of iodb plugin would require much more than just adding an offset server url configuration, I'm still for removing it for now completely. The setting, if you look closely, is stored deep into OffsetServer classes which are to go.

comment:3 in reply to:  2 Changed 7 years ago by akks

Replying to Zverikk:

Since the inclusion of iodb plugin would require much more than just adding an offset server url configuration, I'm still for removing it for now completely. The setting, if you look closely, is stored deep into OffsetServer classes which are to go.

Storing settings should be of course removed. Modification of GUI is not principal but should be discussed (because it is about future strategy).

Last edited 7 years ago by akks (previous) (diff)

comment:4 Changed 7 years ago by Zverikk

I doubt many users ever open settings panel of a TMS/WMS except of curiosity, so the importance of those few text fields and comboboxes is overrated, as well as its impact on a strategy (does josm even have one?).

comment:5 Changed 7 years ago by akks

It was just an option. So we have 3 options:

  1. Apply patch as is
  2. Apply patch leavind disabled config field for future use
  3. (bad one) Do not aply the patch
  4. Apply the patch after tested.

@team: what is your opinion?


comment:6 Changed 7 years ago by stoecker

If it is dead --> remove it. If parts reappear later, readd them later.

@Zverikk: Yes, josm has a strategy.

comment:7 Changed 7 years ago by akks

Resolution: fixed
Status: newclosed

In 5808/josm:

fix #8549, patch by Zverikk: Remove [deprecated] imagery offset server support

comment:8 Changed 7 years ago by akks

OK, applied as is. Also checked that no plugins contain "OffsetServer" string in code.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.