Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8511 closed defect (fixed)

[Patch] usage of "," in simplify-way.max-error

Reported by: AJoNee Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Change the value of simplify-way.max-error to 0,5 and then use simplify-way-tool

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if
possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-03-07 02:31:35
Last Changed Author: Don-vip
Revision: 5759
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-03-06 22:41:42 +0100 (Wed, 06 Mar 2013)
Last Changed Rev: 5759

Identification: JOSM/1.5 (5759 de)
Memory Usage: 247 MB / 247 MB (69 MB allocated, but free)
Java version: 1.7.0_07, Oracle Corporation, Java HotSpot(TM) Client VM
Operating system: Windows 7
Dataset consistency test: No problems found

Plugin: AddrInterpolation (29210)
Plugin: FixAddresses (29210)
Plugin: HouseNumberTaggingTool (29210)
Plugin: RoadSigns (29232)
Plugin: mirrored_download (29210)
Plugin: openstreetbugs (29210)
Plugin: osmarender (29210)
Plugin: print (29210)
Plugin: public_transport (29222)
Plugin: terracer (29210)
Plugin: turnrestrictions (29210)
Plugin: utilsplugin2 (29241)

java.lang.NumberFormatException: For input string: "0,5"
	at sun.misc.FloatingDecimal.readJavaFormatString(Unknown Source)
	at java.lang.Double.parseDouble(Unknown Source)
	at org.openstreetmap.josm.actions.SimplifyWayAction.simplifyWay(SimplifyWayAction.java:152)
	at org.openstreetmap.josm.actions.SimplifyWayAction.actionPerformed(SimplifyWayAction.java:105)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPresse

Attachments (1)

SimplyfyWayParseErrorPatch.diff (1.0 KB) - added by Lesath 7 years ago.
Patch for the crashing of josm with a wrong locale value

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Lesath

Seem that the number parser is not correctly used. As a workaround you could simply use the "0.5" value - this is the english number format.

Changed 7 years ago by Lesath

Patch for the crashing of josm with a wrong locale value

comment:2 Changed 7 years ago by Lesath

Resolution: fixed
Status: newclosed
Summary: usage of "," in simplify-way.max-error[Patch] usage of "," in simplify-way.max-error

Could someone check this in?

comment:3 Changed 7 years ago by stoecker

Resolution: fixed
Status: closedreopened

comment:4 Changed 7 years ago by akks

Sorry for incorrect closing, committing the patch now.

comment:5 Changed 7 years ago by akks

Resolution: fixed
Status: reopenedclosed

Forgot to mention thee ticket number in commit message.

Fixed in [5780/josm], patch applied (slightly formatted).

Note: all numbers with "," are still considered zero without warning!

comment:6 Changed 7 years ago by Don-vip

In 5781/josm:

see #8511 - fix another similar issue

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.