Modify

Opened 7 years ago

Closed 7 years ago

#8480 closed defect (fixed)

[Patch] Validator complains about village addresses

Reported by: balrog-kun Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: validator, addresses Cc:

Description

Since recently validator treats address nodes with addr:place and no addr:street, as problematic. In at least a few countries in Eastern Europe small villages have no street names so adding addr:street would logically be wrong, this is why addr:place is used instead. The validator should probably check whether either of the two tags is present before flagging an object. This is what the attached patch does (not compile tested, sorry). Another check could be whether there exists a place node or relation with the given name within some radius.

Attachments (1)

validate-village-addrs.patch (1.4 KB) - added by balrog-kun 7 years ago.
Proposed fix

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by balrog-kun

Proposed fix

comment:1 Changed 7 years ago by Don-vip

Summary: Validator complains about village addresses[Patch] Validator complains about village addresses

Thanks for the patch, highly appreciated.

I will review it very soon :)

comment:2 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5748/josm:

fix #8480 - Validator: don't raise address warning if house number contains addr:place (patch by balrog-kun)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.