Modify

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#8447 closed enhancement (fixed)

Settings for helper "rubber" line

Reported by: andygol Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

I searched but didn't find settings for helper "rubber" line for adjusting it appearance.
How I can set it colour, width and style (dotted, dashed, solid. etc)? Can somebody add options to adjust it?

Attachments (0)

Change History (14)

comment:1 Changed 7 years ago by stoecker

You can turn it on/off. Color is the select color. Style cannot be changed.

comment:2 Changed 7 years ago by akks

What if I add common options for line style (width, pattern)? (color is separate)
This can be customized in different places (rubber line, extrude, improveWayAccuracy, etc.)
It is not very common to customize them, but if people want...

comment:3 Changed 7 years ago by akks

Let us try it:
draw.stroke.helper-line, draw.anglesnap.stroke.highlight, draw.anglesnap.stroke.helper parameters corresponds the stroke: 2 5 10 means 2px width, 5+10px dashed line. 3 means 3px width solid line.
GuiHelper.getCustomizedStroke is the function that decodes this preference strings.
helper-line color is also customizable (defaults to selected color).


comment:4 Changed 7 years ago by akks

In 5739/josm:

see #8447: advanced preferences to customize helper lines color and stroke

comment:5 Changed 7 years ago by akks

In 5741/josm:

Extrude mode refactoring (func. splitting, javadoc). Use constant directions for Ctrl-Drag.
See #8447: Add color and stroke customization to Extrude mode
fix stroke=1 0 0 exception (minor)

comment:6 Changed 7 years ago by BathoryPeter

Maybe a mistake in change 5741...
In this line:

rubberLineColor = Main.pref.getColor(marktr("draw.helper-line"), null);

are you sure "draw.helper-line" is translatable?

(http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java#L205)

comment:7 Changed 7 years ago by stoecker

In 5768/josm:

see #8447 - fix color name

comment:8 Changed 7 years ago by stoecker

It is indeed, but it should be "helper line" only.

comment:9 Changed 7 years ago by akks

Thank you. Never understood this color-translating features :)

Are you sure that there is only one line called "helper line"?
Are the translations in Extrude action correct?
http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java?rev=5741#L199

Last edited 7 years ago by akks (previous) (diff)

comment:10 Changed 7 years ago by stoecker

Color translations is easy. Simply use a user visible translatable string. The code behind will convert it into a color code. There are no hidden colors - all colors are user configurable always.

comment:11 Changed 6 years ago by akks

Resolution: fixed
Status: newclosed

In 6028/josm:

fix #8447: last color & stroke customization added: ImproveWayAccuracy and ParallelWay

comment:12 Changed 6 years ago by stoecker

Could you change the name, so a human understands it --> iwa to improve way accuracy?

comment:13 Changed 6 years ago by akks

Ok, I'll change it. Are the color names suitable?

comment:14 Changed 6 years ago by akks

In 6029/josm:

see #8447: improvewayaccuracy - rename configuration parameters

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.