Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8383 closed enhancement (fixed)

WIWOSM: Test for 'wikipedia'-tags missing language

Reported by: jjaf.de Owned by: team
Priority: major Milestone:
Component: Core Version: latest
Keywords: WIWOWSM wikipedia missing-language broken-log Cc:

Description

The WIWOSM error-log shows 44K+ entries of incorrect 'wikipedia'-tagging.

The Projekt would need a validator-test, so editors will be alerted while editing in their region.

Correct tagging would be:
'wikipedia' = '<language>:<article>'

Optionally the validity of language can be checked by comparing to a list extracted from a WP-API-sitematrix-call in <api><sitematrix><language code="$language"> which could be copied to JOSM as it does not change very often.

Most common error currently is having no language at all, thus having no ":"-delimiter in the 'wikipedia'-tag.

Other 'wikipedia:*'-tags could be ignored for the test by now.

This test would help the WIWOSM-project very much.

Attachments (0)

Change History (7)

comment:1 Changed 7 years ago by jjaf.de

Looking at the present validation-modules i wonder wether TagChecker could do the job by configuring tagchecker.cfg.
I converted the mentioned WP-API-call to a text-file giving 293 valid WP-language-codes. Maybe too much for tagchecker.cfg? I will try to code a test there to include it in the JOSM-preferences 'validator.TagChecker.sources'.

comment:2 Changed 7 years ago by bastiK

Resolution: fixed
Status: newclosed

In 5683/josm:

fixed #8383 - WIWOSM: Test for 'wikipedia'-tags missing language (idea by jjaf)

comment:3 Changed 7 years ago by bastiK

Hope that works for you.

comment:4 Changed 7 years ago by jjaf.de

I made a working tagchecker.cfg-add-on to be configured as an additional source. It works for me but i will ask other people to test.
If these tests will be ok, i would request inclusion in main tagchecker.cfg.

I now see the patch made by bastiK. I will have a look at it.

comment:5 Changed 7 years ago by bastiK

In 5685/josm:

improved wikipedia test in tagchecker.cfg (see #8383)

comment:6 Changed 7 years ago by bastiK

I improved it according to your tagchecker.cfg-add-on file. According to the wiki, there are cases, where the form wikipedia:lang=Title can be used, so I'm not sure about the 3rd rule.

comment:7 in reply to:  6 Changed 7 years ago by skyper

Replying to bastiK:

I improved it according to your tagchecker.cfg-add-on file. According to the wiki, there are cases, where the form wikipedia:lang=Title can be used, so I'm not sure about the 3rd rule.

You really need the 3rd rule wikipedia:lang=Title. Often there is a page in only some languages and only a section on a different page in other languages.

Last edited 7 years ago by skyper (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.