Opened 12 years ago
Closed 12 years ago
#8346 closed defect (fixed)
Multipolygon paint style not updated on tag change
Reported by: | AndrewBuck | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | paint, mappaint, multipolygon, tags | Cc: |
Description ¶
==Decsription==
During the course of my mapping of landuse I create many multipolygons by drawing a bunch of untagged ways, combining them into a MP relation with ctrl+alt+a and then applying one or more tags to the MP relation itself. After adding tags to the relation (either with the tag editor plugin, or with a preset, or with the normal 'add tag' dialog (alt+a)), the multipolygon paint style is not completely applied. Often the 'fill color' portion of the paint style gets applied, but the line stroke styling does not get applied right away. If I disable the current paint style, and the re-enable it, to force a repaint of everything, then the paint style does get properly applied to both the area fill and the line strokes.
==Detailed steps to reproduce==
- Draw an untagged inner and outer way (a donut shape)
- Select these two ways and make an MP relation with ctrl+alt+a
- Alt-click on one the ways until the MP relation itself is selected (pink outline and tag display shows only type=multpolygon)
- Add the tag landuse=forest using any tag add method (preset, tag editor, or alt+a)
- Notice that the area fill is applpied but the lines are still painted as untagged
- Disable and re-enable the default josm paint style
- Now both the area fill and the lines are properly styled
==Proposed solution==
Any tag change to a multipolygon relation should force a repaint/restyle event, similar to how changing tags on a way forces a repaint/restyle event. I am not familiar enough with the code to know exactly what method calls these are, but I think this is the underlying problem.
In 5676/josm: