Error while uploading

[D4RKL3G10N]

What steps will reproduce the problem?

1. Open my changeset with the JOSM 5576
2. Attempt to upload it

What is the expected result?
It should upload.

What happens instead?
An error message will appear stating "An unexpected exception occured. This is always a coding error. If you are running the latest version of JOSM, please consider being kind and file a bug report."

Please provide any additional information below. Attach a screenshot if
possible.

Please note the changeset attached. Also, this changeset was created using the "Revert changeset" plugin, since a mapper deleted large chunks of data. So all items there included are previous versions of items already in the database, although the conflicts have been solved.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-11-10 02:31:13
Last Changed Author: bastiK
Revision: 5576
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-11-09 21:16:38 +0100 (Fri, 09 Nov 2012)
Last Changed Rev: 5576

Identification: JOSM/1.5 (5576 en)
Memory Usage: 42 MB / 247 MB (15 MB allocated, but free)
Java version: 1.6.0_37, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows 7

Dataset consistency test:
[SEARCH WAYS] {Way id=87828430 version=3 MT> nodes=[{Node id=26464417 version=4 M }, {Node id=1021051024 version=3 M }]} not found using Dataset.searchWays()


Plugin: OpeningHoursEditor (28656)
Plugin: PicLayer (28807)
Plugin: buildings_tools (28891)
Plugin: reverter (28820)
Plugin: terracer (28807)
Plugin: turnrestrictions (28807)
Plugin: utilsplugin2 (28807)

java.lang.NullPointerException
	at org.openstreetmap.josm.data.validation.util.ValUtil.getWaysInCell(ValUtil.java:41)
	at org.openstreetmap.josm.data.validation.tests.SimilarNamedWays.visit(SimilarNamedWays.java:68)
	at org.openstreetmap.josm.data.osm.Way.visit(Way.java:198)
	at org.openstreetmap.josm.data.validation.Test.visit(Test.java:144)
	at org.openstreetmap.josm.actions.upload.ValidateUploadHook.checkUpload(ValidateUploadHook.java:61)
	at org.openstreetmap.josm.actions.UploadAction.checkPreUploadConditions(UploadAction.java:187)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:210)
	at or

[D4RKL3G10N]

defective changeset

[bastiK]

Your osm file contains a way where the way nodes are not present in the osm file. JOSM does not support incomplete ways. It seems to be a bug of the reverter plugin to produce objects like that.

(You may be able to upload successfully when you turn off validator.)

[D4RKL3G10N]

Indeed, when you use the validator the error message appears, which is why I got the message each time I attempted to upload due to the pre-upload validation. Nonetheless despite deactivating the pre-upload and being able to upload hence, the server rejected the changeset because it "could not parse valid node from xml string. lat missing". I assume it to be related to the possible reverter plugin bug.

So, in my humble and programming laymen's opinion, the error message is caused by the validator, yet the invalid way is generated by the reverter plugin. It's true the reverter shouldn't generate the invalid way, on the other hand the validator should be able to recognize such a way without crashing, right? I may be wrong.

1. The error message and the validator tool:

I apparently isolated what causes the error message ( "An unexpected exception occured. This is always a coding error. If you are running the latest version of JOSM, please consider being kind and file a bug report."). It is an issue with the validator tool, where it can't handle nodes which do not have coordinates. There are around 10 nodes without coordinates in my changeset. Once you delete those nodes the validator tool works normally and the error message doesn't show up anymore.

2. The reverter plugin bug(s):

i) I assume the reverter plugin creates/retrieves:

a) nodes without coordinates as mentioned above, and
b) "phantom" ways, which have 0 nodes and are not visible on the map, even if you search for them by their id numbers, yet remain as members in relations, causing the server to detect the issue. Once you remove these phantom ways from the relations the problem is solved. Since the nodes neither the ways are directly visible, I couldn't find a link between them (maybe the nodes were part of the ways).

There also happened repeatedly conflicts, but I believe that is expected since I deleted these faulty objects.

Thanks,
D4RKL3G10N

[malenki]

Probably this ticket points to the same issue as #8219 does

[skyper]

There are still problems with the reverter after redaction. Have a look at: query

[Don-vip]

Should be fixed in [o29553] (JOSM latest required).