indownloadedarea doesnt work correctly

[fatbozz]

When i use indownloadedarea operator in search, every way is selected, even ways, that are outside bbox. allindownloadedarea works ok

[anonymous]

it was not with tested but r5604

[xeen]

This is not a bug, but the intended behaviour.

• indownloadedarea means: select all ways (and nodes) that intersect the downloaded area (more accurately: it selects all nodes in the download area and all ways that are somehow connected to these nodes. In other words, ways that intersect the download rectangle, but have no node inside do not get selected. I’ll call these non-intersecting-node-ways)
• allindownloadedarea means: select all ways (and nodes) that are completely contained in the downloaded area

So, these operators are in fact different, and not synonyms. The English translation currently uses:

• indownloadedarea: objects in downloaded area
• allindownloadedarea: objects (and all its way nodes / relation members) in downloaded area

I don’t find these tooltips to be very precise because they allow more than one interpretation. E.g., allin could be read as "select everything inside dl-area, and then expand selection to connected objects". Ignoring the fact that "indlarea" does not select non-intersecting-node-ways, I suggest the following rewording. Please point out any ambiguities or other improvements. Operator renaming is obviously optional, and the tooltip applies to the "inview"/"allinview" operators as well:

• in → intersect (intersectdownloadarea, intersectview)

objects with at least one part (object itself, node or member) in the downloaded area.

• allin → inside (insidedownloadarea, insideview)

objects with all parts (object itself, nodes and members) in the downloaded area. This selector is stricter than intersectdownloadedarea.

Latter tooltip might be a bit problematic because a relation doesn’t really have any location in itself, only its members do. The "object itself" notation largely stems from the fact that nodes really don’t have any parts. Suggestions welcome.