Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8208 closed defect (fixed)

Incorrect key="color" in defaultpresets.xml

Reported by: sznik Owned by: team
Priority: normal Milestone:
Component: Internal preset Version: tested
Keywords: defaultpresets.xml Cc:

Description

Items "Route", "Route master", "Directional Route (North America)" have key="color" instead of key="colour"

Attachments (0)

Change History (13)

comment:1 Changed 10 years ago by stoecker

According to taginfo color should really be fixed to colour.

comment:2 Changed 10 years ago by bastiK

color is used more often than colour: http://taginfo.openstreetmap.org/tags/?key=type&value=route#combinations

On the wiki page the spelling has been changed back and forth.

comment:3 in reply to:  2 Changed 10 years ago by simon04

Replying to bastiK:

color is used more often than colour: http://taginfo.openstreetmap.org/tags/?key=type&value=route#combinations

That might be due to the JOSM preset.

On the wiki page the spelling has been changed back and forth.

Arg. This "no one never decides anything" is sometimes a bit annoying (cf. also the emergency/amenity=aed).

comment:4 in reply to:  2 Changed 10 years ago by stoecker

Replying to bastiK:

color is used more often than colour: http://taginfo.openstreetmap.org/tags/?key=type&value=route#combinations

Only for route. Overall colour is much more accepted than color. So I think the "color" advantage in this case is only to our own error :-)

comment:7 Changed 10 years ago by stoecker

Well, American vs. British. I also wonder why this keywords is British, whereas most of the others are American, but probably JOSM is not the right instance to enforce the language here :-)

comment:8 in reply to:  7 ; Changed 10 years ago by bastiK

Replying to stoecker:

Well, American vs. British. I also wonder why this keywords is British, whereas most of the others are American, but probably JOSM is not the right instance to enforce the language here :-)

Historically, British English is the predominant spelling in OSM, e.g. place=neighbourhood, leisure=sports_centre, etc., but it would be interesting to see real usage stats for this aspect.

I would vote for the change to colour, although I do not see why my voice should count more than that of a random mapper. ;)

comment:9 in reply to:  8 Changed 10 years ago by skyper

Replying to bastiK:

Replying to stoecker:

Well, American vs. British. I also wonder why this keywords is British, whereas most of the others are American, but probably JOSM is not the right instance to enforce the language here :-)

Historically, British English is the predominant spelling in OSM, e.g. place=neighbourhood, leisure=sports_centre, etc., but it would be interesting to see real usage stats for this aspect.

As far as I remember it: OSM uses BE but the users often do not follow this rule. At least that is what I read several times on tagging@osm
Same with the JOSM wiki where I often read dialog instead of dialogue for example (wiki:Translations).

I would vote for the change to colour, although I do not see why my voice should count more than that of a random mapper. ;)

+1

Solution would be to have a decision, write it down and follow it.

comment:10 Changed 10 years ago by stoecker

Resolution: fixed
Status: newclosed

In 5597/josm:

fix #8208 - colour key spelling

comment:11 Changed 10 years ago by stoecker

@skyper: JOSM and JOSM wiki are clearly AE.

I now changed the preset and modified it to fit reality better. Also updated the OSM wiki page for "colour" key a bit (also telling our mistake :-).

comment:12 in reply to:  11 Changed 10 years ago by skyper

Replying to stoecker:

@skyper: JOSM and JOSM wiki are clearly AE.

Strange I thought I'd read it somewhere a long time ago. Probably was wrong.
Where is the right place to write this on the wiki ?

comment:13 Changed 10 years ago by stoecker

Don't know about OSM. I talk about JOSM :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.