Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#8208 closed defect (fixed)

Incorrect key="color" in defaultpresets.xml

Reported by: sznik Owned by: team
Priority: normal Milestone:
Component: Internal preset Version: tested
Keywords: defaultpresets.xml Cc:

Description

Items "Route", "Route master", "Directional Route (North America)" have key="color" instead of key="colour"

Attachments (0)

Change History (13)

comment:1 by stoecker, 11 years ago

According to taginfo color should really be fixed to colour.

comment:2 by bastiK, 11 years ago

color is used more often than colour: http://taginfo.openstreetmap.org/tags/?key=type&value=route#combinations

On the wiki page the spelling has been changed back and forth.

in reply to:  2 comment:3 by simon04, 11 years ago

Replying to bastiK:

color is used more often than colour: http://taginfo.openstreetmap.org/tags/?key=type&value=route#combinations

That might be due to the JOSM preset.

On the wiki page the spelling has been changed back and forth.

Arg. This "no one never decides anything" is sometimes a bit annoying (cf. also the emergency/amenity=aed).

in reply to:  2 comment:4 by stoecker, 11 years ago

Replying to bastiK:

color is used more often than colour: http://taginfo.openstreetmap.org/tags/?key=type&value=route#combinations

Only for route. Overall colour is much more accepted than color. So I think the "color" advantage in this case is only to our own error :-)

comment:7 by stoecker, 11 years ago

Well, American vs. British. I also wonder why this keywords is British, whereas most of the others are American, but probably JOSM is not the right instance to enforce the language here :-)

in reply to:  7 ; comment:8 by bastiK, 11 years ago

Replying to stoecker:

Well, American vs. British. I also wonder why this keywords is British, whereas most of the others are American, but probably JOSM is not the right instance to enforce the language here :-)

Historically, British English is the predominant spelling in OSM, e.g. place=neighbourhood, leisure=sports_centre, etc., but it would be interesting to see real usage stats for this aspect.

I would vote for the change to colour, although I do not see why my voice should count more than that of a random mapper. ;)

in reply to:  8 comment:9 by skyper, 11 years ago

Replying to bastiK:

Replying to stoecker:

Well, American vs. British. I also wonder why this keywords is British, whereas most of the others are American, but probably JOSM is not the right instance to enforce the language here :-)

Historically, British English is the predominant spelling in OSM, e.g. place=neighbourhood, leisure=sports_centre, etc., but it would be interesting to see real usage stats for this aspect.

As far as I remember it: OSM uses BE but the users often do not follow this rule. At least that is what I read several times on tagging@osm
Same with the JOSM wiki where I often read dialog instead of dialogue for example (wiki:Translations).

I would vote for the change to colour, although I do not see why my voice should count more than that of a random mapper. ;)

+1

Solution would be to have a decision, write it down and follow it.

comment:10 by stoecker, 11 years ago

Resolution: fixed
Status: newclosed

In 5597/josm:

fix #8208 - colour key spelling

comment:11 by stoecker, 11 years ago

@skyper: JOSM and JOSM wiki are clearly AE.

I now changed the preset and modified it to fit reality better. Also updated the OSM wiki page for "colour" key a bit (also telling our mistake :-).

in reply to:  11 comment:12 by skyper, 11 years ago

Replying to stoecker:

@skyper: JOSM and JOSM wiki are clearly AE.

Strange I thought I'd read it somewhere a long time ago. Probably was wrong.
Where is the right place to write this on the wiki ?

comment:13 by stoecker, 11 years ago

Don't know about OSM. I talk about JOSM :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.