SeaMap Editor broken

[anonymous]

The Seamap Editor seems to be completely broken:

• The Dialog window obstructs the buttons at the bottom (See screen shot)
• If you press the right button you get an exception

[markus@…]

OpenSeamap plugin dialog

[markus@…]

Detail of the exception when pressing the rightmost button.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-08-31 01:31:11
Last Changed Author: Don-vip
Revision: 5485
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-08-31 00:21:56 +0200 (Fri, 31 Aug 2012)
Last Changed Rev: 5485

Identification: JOSM/1.5 (5485 en_GB)
Memory Usage: 133 MB / 247 MB (54 MB allocated, but free)
Java version: 1.6.0_26, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: SeaMapEditor (28541)

java.lang.NullPointerException
	at oseam.seamarks.SeaMark.saveSign(SeaMark.java:2550)
	at oseam.panels.PanelMain$2.actionPerformed(PanelMain.java:40)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at java.awt.Component.processMouseEvent(Component.java:6288)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6053)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4651)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4481)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4481)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:643)
	at java.awt.EventQueue.access$000(EventQueue.java:84)
	at java.awt.EventQueue$1.run(EventQueue.java:602)
	at java.awt.EventQueue$1.run(EventQueue.java:600)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
	at java.awt.EventQueue$2.run(EventQueue.java:616)
	at java.awt.EventQueue$2.run(EventQueue.java:614)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:613)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[anonymous]

For some time I have not been able to switch between IALA-A and IALA-B, somewhat annoying when tagging in IALA-B area and all defaults to IALA-A

[malcolmh]

Please list a step-by-step sequence of events leading up to this. I can then do exactly the same steps to try & re-create the problem.

[anonymous]

1) Download josm-latest.jar (version 5501)

2) Run start josm from the command line:
markus@T60:~/Markus/Charts$ java -jar josm-latest.jar
GET ​http://api.openstreetmap.org/api/capabilities... OK
loading plugin 'SeaMapEditor' (version 28541)
Registered toolbar action dialogs/validator overwritten: org.openstreetmap.josm.actions.ValidateAction gets

3) Create a new (empty) layer: File - Create Layer

4) Start the SeaMap Editor: Tools - SeaMap Editor

-> See the Dialog window with the obstructed the buttons at the bottom (See screen shot)

This time I did not manage to press any of the two buttons and could therefore not recreate the exception.

I run this on a Laptop with Ubuntu 10.04. Here my java version:
markus@T60:~/Markus/Charts$ java -version
java version "1.6.0_26"
Java(TM) SE Runtime Environment (build 1.6.0_26-b03)
Java HotSpot(TM) Client VM (build 20.1-b02, mixed mode, sharing)

[malcolmh]

I have changed two things:

1. The frame is now re-sizeable. The existing fixed-size frame only provides the correct layout on the default look-and-feel setting (Metal). Other settings have wider margins & this causes the overlapping of window components.
2. The "Save" button now remains disabled if no node has been selected. This prevents the exception.

I have tested this on Fedora Linux & MacOS with josm-tested.
Please confirm that you can now use the tool OK.

[anonymous]

I like the disabled 'save' button, thanks.

But the re-sizing the frame is insufficient on my Ubuntu system. You can resize the outside of the window, but the button and textfield remain hidden. See 2nd attached screen-shot.

I also tested on a Windows box, there the OSM window is too small too, although you can resize the window to make the textfield and button visible.

Why don't you make the dialog box big enough, so the textfield and button are visible ?
The problem is the same on Ubuntu and Windows, the dialog box is too small.

Markus

[Markus]

Dialog box with hidden button and textfield (with version 28772)

[malcolmh]

I have now re-sized both frame and tabbed panes. I have tried all look-and-feel styles on both Linux and MacOS. I do not have a Windows system, so if you could check that for me, I would be grateful.

[Markus Baertschi <markus@…>]

A quick test shows that you can see the full Dialog box on Ubuntu and on Windows.
The problem is fixed for me, we can close the ticket !
Excellent, the dialog
Thanks !