Modify

Opened 13 years ago

Closed 12 years ago

#7842 closed enhancement (fixed)

Enhancements for Wikipedia plugin

Reported by: coso Owned by: simon04
Priority: normal Milestone:
Component: Plugin wikipedia Version:
Keywords: Cc:

Description

If I'm not wrong, your plugin can't say if an article is yet present in OSM. It just lists all the nearby articles.

Do you know this tools?
http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl/Add-tags

By watching that I thought at some features that could be added to your plugin:

  1. to let the user hide from the list of articles of your plugin those yet present in OSM,
  1. to suggest articles by category, just like the site in the example: http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl/Add-tags
  1. if "2" it could be useful to let the user configure which category he doesn't want to show up. For example, I may be interested in the category "Churches in Venice" or museums but not in the category "Famous peoples born in Venice", because there aren't information that can go in OSM from that.
  1. show a list of malformed wikipedia tags(http://wiki.openstreetmap.org/wiki/Key:wikipedia). Example of errors:
    • wikipedia=http:\\*
    • there should exists at least one tag wikipedia=language:article, if there are only tags like wikipedia:language=* it must be corrected

Here is a sort of mokup to show some of the features:
http://i.imgur.com/wmTRN.png

Attachments (1)

mockup.png (439.8 KB ) - added by simon04 13 years ago.

Download all attachments as: .zip

Change History (7)

by simon04, 13 years ago

Attachment: mockup.png added

in reply to:  description comment:1 by simon04, 13 years ago

Some changes in ​[o28469], ​[o28470], ​[o28471].

  1. to let the user hide from the list of articles of your plugin those yet present in OSM,

Already linked elements are indicated using a symbol (grey checkmark indicates availability on WIWOSM server, green checkmark in local data set)

  1. to suggest articles by category, just like the site in the example: http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl/Add-tags

Done (click on "Category")

  1. if "2" it could be useful to let the user configure which category he doesn't want to show up. For example, I may be interested in the category "Churches in Venice" or museums but not in the category "Famous peoples born in Venice", because there aren't information that can go in OSM from that.

I wonder whether this is worth the effort. Instead, I could imagine to provide a "Paste from clipboard" functionality, if there is real need.

comment:2 by coso, 13 years ago

Wow, you have been fast :)
Thank you.

I updated the plugin but it seems to crash by now, see ticket #7851 please.

comment:3 by coso, 13 years ago

I don't know if you are aware of this.
By now the plugin get articles from http://toolserver.org/~daniel/WikiSense/CategoryIntersect.php . The csv data it receives are like:
"0 St Mark's Basilica Churches in Venice 1146965"

Only those lines starting with "0" are articles. The plugin instead shows among the articles also the lines starting with 14, which are subcategories:
"14 Churches in Venice Venezia ...."

The plugin shows as articles:

_____________________
St Mark's Basilica
Churches in Venice
_____________________

You may:

  • not show categories in the list,
  • add an icon (a folder or a "+"?) before them, so that if the user double clic on a category the plugin uses it as the new category from which to get the articles,
______________________
St Mark's Basilica
+ Churches in Venice
______________________
  • store the list of categories in another frame under that of the articles and configure the double click to act as in the former point.
_____________________
Articles:
St Mark's Basilica
---------------------
Categories:
Churches in Venice
_____________________

in reply to:  3 ; comment:4 by simon04, 13 years ago

  • not show categories in the list,

Done in [o28486], [o28487].

Concerning your other two ideas: I agree that they would be nice to have. However, by repeatedly querying for different categories, you may obtain the same information. So for the moment, I'd stick with the current list implementation. You might be able to convince me from the importance of the hierarchical representation. :-)

The validation tests will be implemented eventually soon. :-)

in reply to:  4 comment:5 by coso, 13 years ago

Replying to simon04:

  • not show categories in the list,

Done in [o28486], [o28487].

Fine.

Concerning your other two ideas: I agree that they would be nice to have. However, by repeatedly querying for different categories, you may obtain the same information. So for the moment, I'd stick with the current list implementation.

Ok. It's true that by clicking a subcategory there would be shown articles yet present in the list. But this could be a workaround to implement the point "3" of my first message. By showing articles from a chosen subcategory I also remove from the list all the articles I'm not interested in, (for example a long list of people names). I'm not writing to convince you, but just to keep a record here of the pros and cons of the different approaches :-) Thank you for the updates.

The validation tests will be implemented eventually soon. :-)

Just thinking, maybe these would be better as new Validator's warnings.

comment:6 by simon04, 12 years ago

Resolution: fixed
Status: newclosed
  • validation tests for Wikipedia tags have been added to core (r5683, r5685)
  • Pasting articles from clipboard has been added [o29329] in. Thus, category preprocessing can be done with other tools and pasted to JOSM.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.