Selection of deleted objects

[mdk]

I put this under "Core", even if this special error came from the remote control plugin, but I think there are still other ways to select a deleted object.

What steps will reproduce the problem?

1. download an object (in this case a way) using the remote control plugin (I use the keepright Website)
2. Delete the way in JOSM. (selection is now empty)
3. download the same object from keepright again.

What is the expected result?

Nothing should be selected in JOSM, because the way is already deleted.

What happens instead?

The deleted way is selected (you can see it in the selection list, because the way has (0) nodes).

If you delete this way, you get the "is already deleted" exception below.

When you do this with a node or relation instead of a way, the same thing happens. In all cases you can still edit tags of the deleted object, which is confusing. And some operations fail with exceptions like deleting.

Is there any usecase where a deleted node, way or relation should apper in the selection list? I think the method to select objects should generally ignore deleted objects!

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-06-04 01:31:02
Last Changed Author: simon04
Revision: 5267
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-06-03 22:21:06 +0200 (Sun, 03 Jun 2012)
Last Changed Rev: 5267

Identification: JOSM/1.5 (5267 de)
Memory Usage: 85 MB / 494 MB (23 MB allocated, but free)
Java version: 1.7.0_05, Oracle Corporation, Java HotSpot(TM) Client VM
Operating system: Windows XP
Dataset consistency test: No problems found

Plugin: ColumbusCSV (28043)
Plugin: OpeningHoursEditor (28412)
Plugin: SimplifyArea (27905)
Plugin: buildings_tools (28412)
Plugin: contourmerge (1003)
Plugin: licensechange (28412)
Plugin: measurement (28412)
Plugin: openstreetbugs (28412)
Plugin: public_transport (28412)
Plugin: reverter (28412)
Plugin: terracer (28412)
Plugin: turnrestrictions (28412)
Plugin: undelete (28416)
Plugin: utilsplugin2 (28412)

java.lang.IllegalArgumentException: {Way id=167051863 version=1 MVD nodes=[]} is already deleted
	at org.openstreetmap.josm.command.DeleteCommand.executeCommand(DeleteCommand.java:119)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:54)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:36)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:58)
	at org.openstreetmap.josm.actions.mapmode.DeleteAction.doActionPerformed(DeleteAction.java:152)
	at org.openstreetmap.josm.acti

[bastiK]

Replying to mdk:

Is there any usecase where a deleted node, way or relation should apper in the selection list? I think the method to select objects should generally ignore deleted objects!

My suggestion:

• Change DataSet.getSelected(), such that it automatically filters out deleted objects.
• Add new method DataSet.getAllSelected() that returns all selected objects, including deleted. This would be only used by features that can handle deleted objects, for example SelectionListDialog and InfoAction.

[Don-vip]

In 5360/josm:

fix #7776 - Selection of deleted objects