Modify

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#7732 closed enhancement (wontfix)

Separate error-check code from method logic

Reported by: Locked Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

the null checks in OsmPrimitive#visitReferrers should be seaprated from the method logic

Attachments (1)

OsmPrimitvePatch.patch (1018 bytes ) - added by Locked 13 years ago.
Patch to improve the code

Download all attachments as: .zip

Change History (5)

by Locked, 13 years ago

Attachment: OsmPrimitvePatch.patch added

Patch to improve the code

comment:1 by Locked, 13 years ago

Type: defectenhancement

comment:2 by simon04, 13 years ago

Resolution: wontfix
Status: newclosed

Semantically, I don't see a difference. I don't see a problem with the current code.

Without improvement, such changes are discouraged (see DevelopersGuide/SVN_Account#RulesforJOSMaccount).

comment:3 by Locked, 13 years ago

Just thought it would be more readable to separate sanity null-checks from the business logic.

comment:4 by bastiK, 13 years ago

We don't want patches, that only change the coding style. If you change formatting, only, you are correcting someone else's work, although it's just a matter of taste. If you do change the code (but only for cosmetic reasons), it's discouraged, because it may introduce bugs. Let's focus on new features, improvements, bug fixes, documentation, unit tests, and so on.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.