Attachments (1)
Change History (5)
by , 13 years ago
Attachment: | OsmPrimitvePatch.patch added |
---|
comment:1 by , 13 years ago
Type: | defect → enhancement |
---|
comment:2 by , 13 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Semantically, I don't see a difference. I don't see a problem with the current code.
Without improvement, such changes are discouraged (see DevelopersGuide/SVN_Account#RulesforJOSMaccount).
comment:3 by , 13 years ago
Just thought it would be more readable to separate sanity null-checks from the business logic.
comment:4 by , 13 years ago
We don't want patches, that only change the coding style. If you change formatting, only, you are correcting someone else's work, although it's just a matter of taste. If you do change the code (but only for cosmetic reasons), it's discouraged, because it may introduce bugs. Let's focus on new features, improvements, bug fixes, documentation, unit tests, and so on.
Patch to improve the code