Modify

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#7664 closed defect (invalid)

warn move max elements seems broken

Reported by: dieterdreist Owned by: skyper
Priority: normal Milestone:
Component: Core Version: tested
Keywords: warn move max elements Cc:

Description (last modified by dieterdreist)

There is no warning when I move more stuff then set in the preferences.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-05-02 01:31:00
Last Changed Author: stoecker
Revision: 5210
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-05-01 16:42:42 +0200 (Tue, 01 May 2012)
Last Changed Rev: 5210

Identification: JOSM/1.5 (5210 en)
Memory Usage: 106 MB / 989 MB (8 MB allocated, but free)
Java version: 1.6.0_26, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Linux
Dataset consistency test: No problems found

Attachments (0)

Change History (7)

comment:1 by skyper, 13 years ago

Description: modified (diff)
Version: tested

comment:2 by skyper, 13 years ago

Owner: changed from team to dieterdreist
Status: newneedinfo

Can not reproduce.

Did you try it with a new/empty preferences directory ?

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-05-02 01:31:00
Last Changed Author: stoecker
Revision: 5210
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-05-01 16:42:42 +0200 (Tue, 01 May 2012)
Last Changed Rev: 5210

Identification: JOSM/1.5 (5210 en_GB)
Memory Usage: 282 MB / 592 MB (32 MB allocated, but free)
Java version: 1.7.0_03-icedtea, Oracle Corporation, OpenJDK 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

in reply to:  2 ; comment:3 by dieterdreist, 13 years ago

Owner: changed from dieterdreist to skyper

Replying to skyper:

Can not reproduce.

Did you try it with a new/empty preferences directory ?

I tried it now and you are right: behaves like it should. Which setting should I check to get the warning back? I don't want to delete the whole preferences.

in reply to:  3 comment:4 by skyper, 13 years ago

Resolution: invalid
Status: needinfoclosed

Replying to dieterdreist:

Replying to skyper:

Can not reproduce.

Did you try it with a new/empty preferences directory ?

I tried it now and you are right: behaves like it should. Which setting should I check to get the warning back? I don't want to delete the whole preferences.

I did not know either but a simple diff between the default preferences and one with the dialogue surpressed offers you:

-   <tag key='message.movedManyElements' value='false'/>
-   <tag key='message.movedManyElements.value' value='1'/>

You should be fine with deleting the entries with "message.movedManyElements" in the advanced settings.

comment:5 by dieterdreist, 13 years ago

Thank you. I set <tag key='message.movedManyElements' value='false'/> to true and it worked. The other option doesn't seem to exist any more, am I right?

<tag key='message.movedManyElements.value' value='1'/>

when I set this to any number below 20, it doesn't change the behaviour, the limit is always 20. The default is "-1" which I now set. I think we could set this to a lower default, maybe 5. An even better suggestion is from the mailing list: change moving ways from "drag" to "SHIFT+drag", as this should not be a very frequent editing option (besides moving buildings, for which you could use the override with SHIFT).

in reply to:  5 comment:6 by skyper, 13 years ago

Replying to dieterdreist:

Thank you. I set <tag key='message.movedManyElements' value='false'/> to true and it worked. The other option doesn't seem to exist any more, am I right?

<tag key='message.movedManyElements.value' value='1'/>

when I set this to any number below 20, it doesn't change the behaviour, the limit is always 20. The default is "-1" which I now set. I think we could set this to a lower default, maybe 5.

The first is used to set wether to show/hide the dialogue, the second is for the decision you made (yes/no). This has nothing to do with the number of objects.

Deleting the entries means the default values will be used that is why I told you to delete them.

An even better suggestion is from the mailing list: change moving ways from "drag" to "SHIFT+drag", as this should not be a very frequent editing option (besides moving buildings, for which you could use the override with SHIFT).

Please open another ticket for this.

comment:7 by dieterdreist, 12 years ago

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain skyper.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.