Modify

Opened 7 years ago

Closed 7 years ago

#7639 closed enhancement (fixed)

[Patch] Validator should warn about nodes tagged with their way's tags

Reported by: AM909 Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: node tag Cc: AM909

Description

A somewhat common mistake among new editors and importers is to tag the nodes of an area with the same tags as the area way. For example, someone imported a number of vineyards in San Luis Obispo county, California from a college website, tagging both the ways and the nodes with landuse=vineyard, source=extrapolation (whatever that means), and website=...

While the wiki doesn't specify that landuse should not be used on a node, it clearly is wrong/unnecessary in the case where the nodes are part of an area with the same tagging. The validator should warn of such situations.

As of r5181.

Attachments (1)

josm-7639_warnings.osm (8.6 KB) - added by mrwojo 7 years ago.
An extract from Seattle showing four ways tagged building=yes also with nodes tagged building=yes.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by mrwojo

Attachment: josm-7639_warnings.osm added

An extract from Seattle showing four ways tagged building=yes also with nodes tagged building=yes.

comment:1 Changed 7 years ago by mrwojo

I've created a gist on github with a trivial approach to this validation: https://gist.github.com/2789445 (If you want to try this out, don't forget to add the class to the OsmValidator.allAvailableTests list.)

It finds 21 instances in the May 14, 2012 Seattle extract from http://metro.teczno.com/ . All 21 appear to be actual problems (the josm-7639_warnings.osm attachment shows four buildings it found).

The check is simple and conservative (exact tag set matches only, ignores certain tag sets like {source=PGS}). Do you think that's sufficient?

comment:2 Changed 7 years ago by simon04

Summary: Validator should warn about nodes tagged with their way's tags[Patch] Validator should warn about nodes tagged with their way's tags

I like this test: it's simple and (apparently) does what it should do. I guess, it can be integrated after the end of stabilization phase (DevelopersGuide/Schedule).

comment:3 Changed 7 years ago by simon04

Resolution: fixed
Status: newclosed

In 5272/josm:

fix #7639 - Validator should warn about nodes tagged with their way's tags (patch by mrwojo)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.