Modify

Opened 8 years ago

Closed 8 years ago

#7613 closed enhancement (fixed)

Icons for building entrances

Reported by: huftis Owned by: team
Priority: normal Milestone:
Component: Internal mappaint style Version:
Keywords: Cc:

Description (last modified by simon04)

JOSM currently draws icons for building entrances tagged as building=entrance (using the general building=yes rule), which I have found very useful. But the newer (and better) entrance=* tagging scheme is not supported (https://wiki.openstreetmap.org/wiki/Key:entrance). I hereby propose adding the attached icons for this.

There are five icons, entrance-yes.png for entrance=yes *and* building=entrance, entrance-main.png for entrace=main, entrance-service.png for entrance=service, entrance-exit.png for entrance=exit and entrance-emergency for entrance=emergency. The icons for yes, main, service only differ in colour. The icon for entrance=exit could have used the same colour as for entrance=yes (but different icon), but I think it’s much clearer with a dark red colour, to distinguish it from the entrance signs. The icon for emergency exits is the normal emergency icon symbol.

The entrance and exits icons are taken from http://www.sjjb.co.uk/mapicons/ (license CC0). The emergency exit icon is taken from Wikipedia, http://en.wikipedia.org/wiki/File:PublicInformationSymbol_EmergencyExit.svg (‘The copyright holder of this work allows anyone to use it for any purpose including unrestricted redistribution, commercial use, and modification.’).

Here are the style rules for the icons. Note that there already is listed a general k="building" ‘work in progress’ rule at the bottom of elemstyles.xml, which should be removed.

        <rule>
                <condition k="building" v="entrance" />
                <icon annotate="true" src="misc/entrance-yes.png" priority="100"/>
        </rule>
        
        <rule>
                <condition k="entrance" v="yes" />
                <icon annotate="true" src="misc/entrance-yes.png"/>
        </rule>
        
        <rule>
                <condition k="entrance" v="main" />
                <icon annotate="true" src="misc/entrance-main.png"/>
        </rule>
        
        <rule>
                <condition k="entrance" v="service" />
                <icon annotate="true" src="misc/entrance-service.png"/>
        </rule>
        
        <rule>
                <condition k="entrance" v="exit" />
                <icon annotate="true" src="misc/entrance-exit.png"/>
        </rule>
        
        <rule>
                <condition k="entrance" v="emergency" />
                <icon annotate="true" src="misc/entrance-emergency.png"/>
        </rule>

Attachments (1)

entrance-icons.tar.gz (1.9 KB) - added by huftis 8 years ago.
Icons for entrance nodes

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by huftis

Attachment: entrance-icons.tar.gz added

Icons for entrance nodes

comment:1 Changed 8 years ago by simon04

Description: modified (diff)

comment:2 Changed 8 years ago by huftis

Note that when I wrote about the k="building" ‘work in progress’ rule, I of course meant the k="entrance" rule.

comment:3 Changed 8 years ago by simon04

Resolution: fixed
Status: newclosed

In 5190/josm:

fix #7613 - Icons for building entrances

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.