[Patch] [mirrored_download] More intuitive position of menu entries

[simon04]

Recent core changes (r5089) give more control on the position of menu entries.

I suggest:

• to add Download from OSM mirror... directly after Download from OSM...
• to rename Select URL... to Select OSM mirror URL, move it to the edit menu and remove the shortcut (as, presumably, this is not needed very frequently).

I'm not familiar with the usual way of improving plugins (whether to commit directly or discuss with plugin creator).

[bastiK]

Replying to simon04:

Recent core changes (r5089) give more control on the position of menu entries.

I suggest:

• to add Download from OSM mirror... directly after Download from OSM...
• to rename Select URL... to Select OSM mirror URL, move it to the edit menu and remove the shortcut (as, presumably, this is not needed very frequently).

I'm not familiar with the usual way of improving plugins (whether to commit directly or discuss with plugin creator).

I'd discuss larger changes with the original author, but wouldn't bother for small fixes or when the plugin author's last commit is long ago. Basically no one owns the code, but general courtesy applies. :)

[simon04]

Fixed in o28106, o28107. I hope that I performed the steps in the correct order (DevelopersGuide/DevelopingPlugins).

[bastiK]

The manifest of the new binary is

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.8.3
Created-By: 1.7.0_03-icedtea-b147 (Oracle Corporation)
Author: Roland M. Olbricht
Plugin-Class: mirrored_download.MirroredDownloadPlugin
Plugin-Date: 2012-03-16T21:50:32.217584Z
Plugin-Description: Simplifies download from different read-only APIs.
Plugin-Link: http://wiki.openstreetmap.org/wiki/JOSM/Plugins/mirrored_
 download
Plugin-Mainversion: 5089
Plugin-Version: 28106

Last two lines are important, it's correct in this case. Also interesting: ​http://josm.openstreetmap.de/plugin. In the section mirrored_download there is a new line, because you changed the "main version".

[roland.olbricht]

Ok, the plugin worked at least with josm-latest.jar. I'll wait until is has propagated and try then whether it works also with josm-tested, where works means that josm-tested should get the old version.

BTW: Is it really a good idea to rely on features after the last josm-latest? This means that anybody who uses both josm-latest and josm-tested at least needs to reload the plugins at every switch between tested and latest. Does JOSM downgrade plugin version, which would be necessary to then use the plugin in josm-tested at all?

[bastiK]

Replying to roland.olbricht:

Ok, the plugin worked at least with josm-latest.jar. I'll wait until is has propagated and try then whether it works also with josm-tested, where works means that josm-tested should get the old version.

JOSM normally downloads a compatible plugin version, everything else means someone ignored the dev guidelines or there is a bug in the server scripts. :)

BTW: Is it really a good idea to rely on features after the last josm-latest?

josm-latest is always younger than 24 hours, so in practice there aren't really features after that. Even if it was older, this wouldn't be a problem.

This means that anybody who uses both josm-latest and josm-tested at least needs to reload the plugins at every switch between tested and latest. Does JOSM downgrade plugin version, which would be necessary to then use the plugin in josm-tested at all?

It is not intended that josm-tested and josm-latest run side by side and share config and plugins. Use -Djosm.home=$HOME/.josm-latest Java option to change the preference folder for josm-latest.

[roland.olbricht]

Replying to bastiK:

JOSM normally downloads a compatible plugin version, everything else means someone ignored the dev guidelines or there is a bug in the server scripts. :)

I just received this eMail

When I tried to install the plugin, it
asked me to download newer version of JOSM (5097) but the newest and stable
at the moment is 5047. So I can't install the plugin.

I'm using Windows by the way. Tried on my Mac it's work on a charm. Tried
again on my friend's Windows computer, it asking the same thing.

Thus I assume, there is some bug with the plugin update mechanism. I can't verify this because I don't have a Windows box at hands, but maybe we should stay vigilant.