[patch?] Empty download of GPS results to 0;0 saved to last download location

[Larry0ua]

Hi! Here are steps to reproduce the bug:

1. Open JOSM
2. "Download OSM data"
3. uncheck OSM data, check GPS data. Select an area where there is no gps tracks. Press Download.
4. Open download dialog once again - it opens in 0;0 location. Should remember previous download location.

[xeen]

The actual reason for this is the following: GPX Layers do not remember their download bounds, because they are generally not required. When there is no OSM layer and no GPX data to derive the bounds from, MapView zooms in in (0,0). If a map view is visible, the download dialog takes the visible bounds instead of the one it remembered. Thus it appears as if the download dialog remebered (0,0). Closing the empty GPX layer before opening the download dialog will have it display the correct coordinates. I can think of two solutions: if the GPX layer is the first layer, popup a warning message and don’t create a new layer. The other is implemented in the patch: if there is no GPX data and this is the first layer, zoom to the download bounds instead. I’m not very happy with either approach, so I’ll only attach the patch here but won’t commit it for now.

[stoecker]

@xeen: Status of this?

[Don-vip]

#7976 is related.

[xeen]

This bug doesn’t apply anymore. When downloading an empty (gps track wise) region, no gpx layer is created. Re-opening the download dialog will place it at the same position as before.