When there is an error during saving, original file is lost.

[anonymous]

Josm semms to only save over the file when saving (opening a new FileOutputStream to the file).

The right thing to do would be create a new temporary file and move the temporary file AFTER successfully writing the data over to the position of the old file (File.renameTo(..))

Just a few minutes for a core developer, but could save hours of work ;-)

[Don-vip]

Temporary files are already used when writing .osm files and preferences files.

However, the code could be improved as we have several "copy" implementations (at least Preferences.copyFile() and OsmExporter.copy that could be simply replaced to ​Files.copy when we will switch to Java 7.

[Don-vip]

In 5874/josm:

see #8570, #7406 - I/O refactorization:

• Move different file copy functions to Utils.copyFile (to be replaced later by Files.copy when switching to Java 7)
• Replace all Utils.close(XXX) by Utils.close(Closeable) -> impacted plugins: commandline, mirrored_download, opendata, piclayer
• Add new Utils.close(ZipFile)
• Use of Utils.close almost everywhere
• Javadoc fixes

[aceman]

Is this still open?