Opened 14 years ago

Closed 13 years ago

#734 closed enhancement (fixed)

rendering: avoid drawing twice

Reported by: dnaber Owned by: framm
Priority: minor Milestone:
Component: Core Version:
Keywords: performance Cc:


In MapPaintVisitor.visit(), do we really need this line?:

Draw segments in a different colour so direction arrows show against the fill
drawSeg(lastN, n, w.selected ? selectedColor : untaggedColor, showDirection, width, true);

A few lines below, almost exactly the same method is called again (using dashed instead of true as the last parameter, and a different color in case of !w.selected), sometimes drawing the same line again. I tried to comment out the first drawSeg call and it does indeed make rendering quite a bit faster. I didn't see what use case is broken by removing that statement.

Attachments (0)

Change History (1)

comment:1 Changed 13 years ago by anonymous

Resolution: fixed
Status: newclosed

Fixed in r757.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.