Opened 14 years ago
Closed 14 years ago
#7306 closed defect (fixed)
conflict management creating duplicate nodes, validator not finding all problems at once with r4857
Reported by: | dieterdreist | Owned by: | team |
---|---|---|---|
Priority: | blocker | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | duplicate conflict validator | Cc: |
Description
When I tried to upload a changeset JOSM told me that one item was supposedly deleted on the server and asked me to synchronize the dataset. First I tried to synchronize only one item, but for continuous error alerts which followed subsequently I did "synchronize" the whole dataset. This led to masses of duplicate nodes and ways and one conflict in a way with 0 members. I resolved the conflicts (no member conflicts, only tags).
After this I tried to upload my fixed data but got this message: "Failed to upload to changeset 10,474,051 because it has already been closed on 1/23/12 12:44 PM".
Another problem I noticed: the validator seems to find errors and warnings only partially. Every time I hit "validation" after I fixed some problems like duplicate nodes (I usually merged them manually) I got new issues which hadn't been there before.
In another attempt I got this problem: "Failed to upload data to or download data from 'http://api.openstreetmap.org/api/0.6/' due to a problem with transferring data. Details(untranslated): Read timed out"
And yet another try (uploading to _open_ changeset) led to this: "Uploading failed because the server has a newer version of one of your nodes, ways, or relations. The conflict is caused by the relation with id 1,983,550, the server has version 3, your version is 2. Click Synchronize relation 1,983,550 only to synchronize the conflicting primitive only. Click Synchronize entire dataset to synchronize the entire local dataset with the server. Click Cancel to abort and continue editing"
I did "cancel" now, to avoid further manual fixing of duplicates.
Attachments (1)
Change History (8)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
Priority: | critical → blocker |
---|
Keep getting conflicts and decided to use an older Version for now. Raised importance.
comment:3 by , 14 years ago
Summary: | conflict management creating duplicate nodes, validator not finding all problems at once → conflict management creating duplicate nodes, validator not finding all problems at once with r4857 |
---|
I had some conflict problems as well on 2 changesets I uploaded with r4857. Thankfully everything got uploaded fine.
comment:4 by , 14 years ago
Went back to 4842 and loaded (local) and updated (from server) the data I couldn't upload in latest. Then resolved the 2 conflicts. When I clicked on apply for the 2nd conflict I got this unhandled exception:
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2012-01-22 02:32:16 Last Changed Author: stoecker Revision: 4842 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2012-01-21 23:58:25 +0100 (Sat, 21 Jan 2012) Last Changed Rev: 4842 Identification: JOSM/1.5 (4842 en) Memory Usage: 63 MB / 989 MB (19 MB allocated, but free) Java version: 1.6.0_26, Sun Microsystems Inc., Java HotSpot(TM) Client VM Operating system: Linux Dataset consistency test: [DELETED REFERENCED] {Relation id=1984184 version=1 VT [way 147029098, way 147029106, way 147029101]} refers to deleted primitive {Way id=147029101 version=1 MVD nodes=[]} [DELETED REFERENCED] {Relation id=1984185 version=1 VT [way 147029105, way 147029102, way 147029104, way 147029107, way 147029101, way 147029099]} refers to deleted primitive {Way id=147029101 version=1 MVD nodes=[]} Plugin: ImportImagePlugin (27354) Plugin: OpeningHoursEditor (27355) Plugin: PicLayer (27403) Plugin: buildings_tools (27562) Plugin: dataimport (27289) Plugin: licensechange (27472) Plugin: measurement (27289) Plugin: multipoly-convert Plugin: osmarender (27309) Plugin: pdfimport (27355) Plugin: photo_geotagging (27401) Plugin: proj4j (27289) Plugin: public_transport (27355) Plugin: restart (27289) Plugin: reverter (27393) Plugin: tagging-preset-tester (27289) Plugin: undelete (27395) Plugin: utilsplugin2 org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted member referenced: {Relation id=1984185 version=1 VT [way 147029105, way 147029102, way 147029104, way 147029107, way 147029101, way 147029099]} at org.openstreetmap.josm.data.osm.Relation.checkMembers(Relation.java:478) at org.openstreetmap.josm.data.osm.Relation.fireMembersChanged(Relation.java:485) at org.openstreetmap.josm.data.osm.Relation.setMembers(Relation.java:59) at org.openstreetmap.josm.data.osm.DataSet.unlinkPrimitiveFromRelations(DataSet.java:853) at org.openstreetmap.josm.data.osm.DataSet.unlinkReferencesToPrimitive(DataSet.java:874) at org.openstreetmap.josm.command.DeletedStateConflictResolveCommand.executeCommand(DeletedStateConflictResolveCommand.java:62) at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:53) at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:36) at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:58) at org.openstreetmap.josm.gui.dialogs.ConflictResolutionDialog$ApplyResolutionAction.actionPerformed(ConflictResolutionDialog.java:210) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236) at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272) at java.awt.Component.processMouseEvent(Component.java:6288) at javax.swing.JComponent.processMouseEvent(JComponent.java:3267) at java.awt.Component.processEvent(Component.java:6053) at java.awt.Container.processEvent(Container.java:2041) at java.awt.Component.dispatchEventImpl(Component.java:4651) at java.awt.Container.dispatchEventImpl(Container.java:2099) at java.awt.Component.dispatchEvent(Component.java:4481) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168) at java.awt.Container.dispatchEventImpl(Container.java:2085) at java.awt.Window.dispatchEventImpl(Window.java:2478) at java.awt.Component.dispatchEvent(Component.java:4481) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:643) at java.awt.EventQueue.access$000(EventQueue.java:84) at java.awt.EventQueue$1.run(EventQueue.java:602) at java.awt.EventQueue$1.run(EventQueue.java:600) at java.security.AccessController.doPrivileged(Native Method) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98) at java.awt.EventQueue$2.run(EventQueue.java:616) at java.awt.EventQueue$2.run(EventQueue.java:614) at java.security.AccessController.doPrivileged(Native Method) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87) at java.awt.EventQueue.dispatchEvent(EventQueue.java:613) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:178) at java.awt.Dialog$1.run(Dialog.java:1046) at java.awt.Dialog$3.run(Dialog.java:1098) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Dialog.show(Dialog.java:1096) at java.awt.Component.show(Component.java:1584) at java.awt.Component.setVisible(Component.java:1536) at java.awt.Window.setVisible(Window.java:842) at java.awt.Dialog.setVisible(Dialog.java:986) at org.openstreetmap.josm.gui.dialogs.ConflictResolutionDialog.setVisible(ConflictResolutionDialog.java:62) at org.openstreetmap.josm.gui.dialogs.ConflictDialog.resolve(ConflictDialog.java:145) at org.openstreetmap.josm.gui.dialogs.ConflictDialog.access$000(ConflictDialog.java:56) at org.openstreetmap.josm.gui.dialogs.ConflictDialog$ResolveAction.actionPerformed(ConflictDialog.java:343) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236) at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272) at java.awt.Component.processMouseEvent(Component.java:6288) at javax.swing.JComponent.processMouseEvent(JComponent.java:3267) at java.awt.Component.processEvent(Component.java:6053) at java.awt.Container.processEvent(Container.java:2041) at java.awt.Component.dispatchEventImpl(Component.java:4651) at java.awt.Container.dispatchEventImpl(Container.java:2099) at java.awt.Component.dispatchEvent(Component.java:4481) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168) at java.awt.Container.dispatchEventImpl(Container.java:2085) at java.awt.Window.dispatchEventImpl(Window.java:2478) at java.awt.Component.dispatchEvent(Component.java:4481) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:643) at java.awt.EventQueue.access$000(EventQueue.java:84) at java.awt.EventQueue$1.run(EventQueue.java:602) at java.awt.EventQueue$1.run(EventQueue.java:600) at java.security.AccessController.doPrivileged(Native Method) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98) at java.awt.EventQueue$2.run(EventQueue.java:616) at java.awt.EventQueue$2.run(EventQueue.java:614) at java.security.AccessController.doPrivileged(Native Method) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87) at java.awt.EventQueue.dispatchEvent(EventQueue.java:613) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161) at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
comment:5 by , 14 years ago
I can confirm that at least in my case conflict resolution doesn't work in 4842 either (maybe due to not closed changeset?)
I resolve the conflicts, then try to upload and get this:
Failed to delete way 147,020,751. It is still referred to by relation 1984185. Please load the relation, remove the reference to the way, and upload again. Click Prepare conflict resolution to load them now. If necessary JOSM will create conflicts which you can resolve in the Conflict Resolution Dialog
again I resolve and keep getting the same conflict.
Now I closed all open changesets (again, in this case it reported 2 open changesets) and did again "update data". Now I get 3 conflicts. And another alert: "There is 1 object in your local dataset which might be deleted on the server. If you later try to delete or update this the server is likely to report a conflict. Click Check on the server to check the state of this object on the server. Click Ignore to ignore" (still during "update data", so actually I already was checking on the server). Again, it doesn't work, I got another "unhandled exception". Will try a rather old version now.
by , 14 years ago
Attachment: | 20120123-temp.osm added |
---|
comment:6 by , 14 years ago
I attached the file that creates the problem (was saved with the latest version=r4857). Also with 4806 I had the same problem (load, update data, when resolving conflicts (I took "mine") there is an unhandled exception).
With 4667 it doesn't work either. Now I get (besides unhandled exceptions in conflict management): "response code 412, precondition failed. Way xy is still used by relation xz"
comment:7 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Caused by low read timeout in latest 4857.
Next step was "closing all open changesets".
Then I did "update only modified".
This led to 8 conflicts.
The streets, buildings and other ways with conflicts all had 0 nodes (ways with no nodes) and hence only tag conflicts which I resolved all. The three multipolygon-relations had conflicts in the member area, which I also resolved (the "their version" had some members which were incomplete, but "my version was OK", so I dropped "their version", which of course also was mine).
The next attempt to upload went OK (validator showed no errors), but after I downloaded the same area again from the server I got 17 duplicate ways and 16 duplicate nodes in the validator.