Modify

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#7301 closed enhancement (fixed)

[Patch] Shortcuts in relation member editor

Reported by: simon04 Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

I propose to add shortcuts to edit the member list of relations:

  • [Alt]+[Up] to move the selected member(s) up.
  • [Alt]+[Down] to move the selected member(s) down.
  • [Del] to delete the selected member(s).

Here's a patch.

Attachments (1)

rel_shortcut.patch (1.9 KB ) - added by simon04 12 years ago.

Download all attachments as: .zip

Change History (13)

by simon04, 12 years ago

Attachment: rel_shortcut.patch added

comment:1 by akks, 12 years ago

I think it is a good solution. Is it OK for Linux users?

comment:2 by akks, 12 years ago

Do all of us want to eliminate shortcut conflicts before tested version release?

in reply to:  1 comment:3 by simon04, 12 years ago

Replying to akks:

I think it is a good solution. Is it OK for Linux users?

I think [Alt] problem is because one can move windows by holding the [Alt] key (GNOME, KDE SC). The above shortcuts do not involve a mouse action and therefore should not be affected.

comment:4 by akks, 12 years ago

@simon04: Do you plan to commit it?

@team: Are there any problems with this patch?

in reply to:  4 ; comment:5 by bastiK, 12 years ago

Replying to akks:

@simon04: Do you plan to commit it?

Please not in stabilization phase.

@team: Are there any problems with this patch?

Works for me. Maybe treat the AltGr key the same as Alt. I don't like del - if main window has focus, this deletes the object, so it may be confusing.

in reply to:  5 comment:6 by skyper, 12 years ago

Replying to bastiK:

I don't like del - if main window has focus, this deletes the object, so it may be confusing.

+1

or relations, tags, layer or last selection.

comment:7 by simon04, 12 years ago

Use [Alt]+[Del] instead of [Del]? I would not like to map letters (like [D]) to delete as these are typically used to enter the role.

in reply to:  7 comment:8 by skyper, 12 years ago

Replying to simon04:

Use [Alt]+[Del] instead of [Del]? I would not like to map letters (like [D]) to delete as these are typically used to enter the role.

+1

There is also #7288, maybe you can have a look at this ticket, too.

comment:9 by akks, 12 years ago

Resolution: fixed
Status: newclosed

In [4905/josm]:

fix #7288, #7301: based on patch by simon04 / 4 new Relation Editor shortcuts instead of non-working old ones

comment:10 by akks, 12 years ago

<del>

Last edited 12 years ago by akks (previous) (diff)

comment:11 by akks, 12 years ago

Please have a look at changes and reopen this ticket if some more shortcuts should be added.

@simon04: I added registerShortcut calls to your patch to make shortcuts customizable.
Default ones are Alt-Up, Al-Down, Alt-Del and Alt-Home for downloading incomplete members.
I left all other actions without shortcuts (sorting, reversing, etc. - the lines are commented), because they did not work for very long time and no one noticed it :)

comment:12 by simon04, 12 years ago

Nice. :-)

I added a news entry on StartupPage.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.