Modify

Opened 8 years ago

Closed 7 years ago

#7259 closed enhancement (fixed)

[patch] Validation Enhancements for water features

Reported by: oldtopos Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: Validation Cc:

Description

I've modified OverlappingAreas and CrossingWays slightly, such that OverlappingAreas reports water area features separately as Warnings rather than informational.

CrossingWays is modified to report crossing water ways separately.

These changes are a great help when validating the addition of NHD features.

Attachments (1)

validations.diff (9.1 KB) - added by oldtopos 8 years ago.
diff file for validation test changes

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by oldtopos

Attachment: validations.diff added

diff file for validation test changes

comment:1 Changed 8 years ago by stoecker

Summary: Validation Enhancements for water features[patch] Validation Enhancements for water features

comment:2 Changed 8 years ago by simon04

Component: CoreCore validator

The patch looks mostly fine, besides:

  • remove debugging output (System.out.println)
  • use consistent indentation and spacing around parenthesis (e.g., if (!isWaterArea2) {})

Unfortunately, all of this validation tests get very complex when adding special cases (like water areas overlaps, railway overlaps). IMHO, the way to go is to fix the cooperation between filters and validator tests (see #6195). Then, one can specifically filter for cases of interest. Thus, I'd refrain from committing this patch now.

comment:3 Changed 7 years ago by bastiK

Resolution: fixed
Status: newclosed

In 5550/josm:

applied #7259 - Validation Enhancements for water features (patch by oldtopos, slightly modified)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.