#7225 closed enhancement (fixed)
Icons for sport, ford
| Reported by: | Owned by: | team | |
|---|---|---|---|
| Priority: | minor | Milestone: | 16.08 |
| Component: | Core validator | Version: | tested |
| Keywords: | icon | Cc: |
Description
In JOSM there are many icons for sport,
but these icons are overruled by the icon of leasure.
In my opinion it would be better when the sport icon overrules the leasure icon.
In JOSM there is an icon for ford,
but it's not shown for the new ford=yes,
it's shown for the old highway=ford.
Attachments (0)
Change History (12)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
I think this fix is wrong. "ford=yes" is not the same as "ford=yes"&"highway=road". highway=road is for an unspecified road and perfectly correct here.
comment:3 Changed 12 years ago by
Yes, but for nodes (where highway=ford usually has been placed), no highway=* is needed?
comment:5 Changed 12 years ago by
Replying to stoecker:
For nodes yes. For ways it would be wrong.
+1
if the node is only middle part of one way you could also use the highway tag from the way you have to split up.
comment:6 Changed 9 years ago by
| Component: | Core → Internal mappaint style |
|---|
comment:7 follow-up: 8 Changed 9 years ago by
Nothing to do for the first part of this ticket (sport icons are prioritized over leisure icons).
For the second part as already said: when fixing highway=ford to ford=yes it should add highway=road for ways but not for nodes. When this is done this ticket can be closed.
comment:8 follow-up: 9 Changed 9 years ago by
Replying to Klumbumbus:
Nothing to do for the first part of this ticket (sport icons are prioritized over leisure icons).
For the second part as already said: when fixing highway=ford to ford=yes it should add highway=road for ways but not for nodes. When this is done this ticket can be closed.
No, you have to look at the connected highways and find the proper value. Do not think this should be fixed automatically.
comment:9 follow-up: 10 Changed 9 years ago by
Replying to skyper:
No, you have to look at the connected highways and find the proper value.
Hm, I thought highway=road would be better than no highway=* at all.
Do not think this should be fixed automatically.
However it does at the moment. Then we should remove this fix for ways completely!? (For nodes the current behavior is fine.)
comment:10 Changed 9 years ago by
Replying to Klumbumbus:
Replying to skyper:
No, you have to look at the connected highways and find the proper value.
Hm, I thought highway=road would be better than no highway=* at all.
Definitly, it is not wrong and we have a warning about road.
Do not think this should be fixed automatically.
However it does at the moment. Then we should remove this fix for ways completely!? (For nodes the current behavior is fine.)
Well, instead of a warning about ford you will get a warning about road. The warning is just moved and you need another run of validator to get it.
Yes, should not be fixed for ways and I thought it is advised to only use it on ways (wiki), which means we should warn about the use on nodes.
comment:12 Changed 7 years ago by
| Component: | Internal mappaint style → Core validator |
|---|---|
| Milestone: | → 16.08 |
In [4887/josm]: