Modify

Opened 7 years ago

Closed 3 years ago

Last modified 3 years ago

#7225 closed enhancement (fixed)

Icons for sport, ford

Reported by: walterschloegl@… Owned by: team
Priority: minor Milestone: 16.08
Component: Core validator Version: tested
Keywords: icon Cc:

Description

In JOSM there are many icons for sport,
but these icons are overruled by the icon of leasure.
In my opinion it would be better when the sport icon overrules the leasure icon.

In JOSM there is an icon for ford,
but it's not shown for the new ford=yes,
it's shown for the old highway=ford.

Attachments (0)

Change History (12)

comment:1 Changed 7 years ago by simon04

In [4887/josm]:

see #7225 - add style for ford=yes; do not introduce highway=road when fixing deprecated tag highway=ford

comment:2 Changed 7 years ago by stoecker

I think this fix is wrong. "ford=yes" is not the same as "ford=yes"&"highway=road". highway=road is for an unspecified road and perfectly correct here.

comment:3 Changed 7 years ago by simon04

Yes, but for nodes (where highway=ford usually has been placed), no highway=* is needed?

comment:4 Changed 7 years ago by stoecker

For nodes yes. For ways it would be wrong.

Last edited 7 years ago by stoecker (previous) (diff)

comment:5 in reply to:  4 Changed 7 years ago by skyper

Replying to stoecker:

For nodes yes. For ways it would be wrong.

+1

if the node is only middle part of one way you could also use the highway tag from the way you have to split up.

comment:6 Changed 5 years ago by Don-vip

Component: CoreInternal mappaint style

comment:7 Changed 5 years ago by Klumbumbus

Nothing to do for the first part of this ticket (sport icons are prioritized over leisure icons).

For the second part as already said: when fixing highway=ford to ford=yes it should add highway=road for ways but not for nodes. When this is done this ticket can be closed.

comment:8 in reply to:  7 ; Changed 5 years ago by skyper

Replying to Klumbumbus:

Nothing to do for the first part of this ticket (sport icons are prioritized over leisure icons).

For the second part as already said: when fixing highway=ford to ford=yes it should add highway=road for ways but not for nodes. When this is done this ticket can be closed.

No, you have to look at the connected highways and find the proper value. Do not think this should be fixed automatically.

comment:9 in reply to:  8 ; Changed 5 years ago by Klumbumbus

Replying to skyper:

No, you have to look at the connected highways and find the proper value.

Hm, I thought highway=road would be better than no highway=* at all.

Do not think this should be fixed automatically.

However it does at the moment. Then we should remove this fix for ways completely!? (For nodes the current behavior is fine.)

comment:10 in reply to:  9 Changed 5 years ago by skyper

Replying to Klumbumbus:

Replying to skyper:

No, you have to look at the connected highways and find the proper value.

Hm, I thought highway=road would be better than no highway=* at all.

Definitly, it is not wrong and we have a warning about road.

Do not think this should be fixed automatically.

However it does at the moment. Then we should remove this fix for ways completely!? (For nodes the current behavior is fine.)

Well, instead of a warning about ford you will get a warning about road. The warning is just moved and you need another run of validator to get it.

Yes, should not be fixed for ways and I thought it is advised to only use it on ways (wiki), which means we should warn about the use on nodes.

comment:11 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 10916/josm:

fix #7225 - remove autofix for highway=ford ways and suggest to use other highway value; (behavior for nodes didn't change)

comment:12 Changed 3 years ago by Klumbumbus

Component: Internal mappaint styleCore validator
Milestone: 16.08

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.