Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7214 closed enhancement (fixed)

[PATCH] Heap memory growing and CPU load while idle

Reported by: akks Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: memory, performance Cc:

Description

I ran JOSM in the profiler and noticed that constant memory allocation takes place, even when user does not move the mouse. Profiler said it is MapStatus.Collector run method, which regularly invokes statusBarElementUpdate => getNearestNodeOrWay, that need relatively much resources.

In this patch statusBarElementUpdate is called only when mouse position have changed. Profiler shows it removes endless "memory growing - garbage collecting" cycle.

This should do small improvement of JOSM behaviour in the background.

Are there any important cases when statusbar info about element under cursor needs to be updated without moving the mouse?

If it is OK, I can try to commit it.

Attachments (1)

StatusUpdate.patch (1.8 KB) - added by akks 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by akks

Attachment: StatusUpdate.patch added

comment:1 Changed 8 years ago by akks

Resolution: fixed
Status: newclosed

In [4763/josm]:

fix #7214 Memory growing and CPU load while idle (minor change)

comment:2 Changed 8 years ago by akks

Please reopen this ticket if some potential or real problems arise. It is my first commit.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.