identifier for toolbar actions is icon name

[bastiK]

This must be a recent change, but I cannot find the ticket.

The toolbar actions of a JosmAction get identified by the icon name. This is worse than translated name.

(E.g. open button now opens a session because I happen to have the open icon in a submenu.)

[stoecker]

This is there for a very long time (I think it was always this way). One solution is to put a proper "toolbar" value for conflicts. Translated name is still worse, as this means toolbar cannot be built when switching language. But shouldn't you get a warning about such issues in the commandline.

[bastiK]

Yes, there is a warning. I guess I'll add an additional toolbar identifier, that defaults to the icon name.

[bastiK]

In [4733/josm]:

fixed #7174 - identifier for toolbar actions is icon name