#7143 closed defect (worksforme)
Erroneous styles in internal stylesheet
Reported by: | AM909 | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Internal mappaint style | Version: | latest |
Keywords: | elemstyles railway | Cc: | AM909 |
Description
In elemstyles.xml at r4655 , these values at the end of the railway group do not seem to serve a purpose:
<pre>
<rule>
<condition k="service" v="yard"/>
<icon annotate="true" src="misc/deprecated.png"/>
</rule>
<rule>
<condition k="service" v="siding"/>
<icon annotate="true" src="misc/deprecated.png"/>
</rule>
<rule>
<condition k="service" v="spur"/>
<icon annotate="true" src="misc/deprecated.png"/>
</rule>
</pre>
since they do not render a line or area, and are already rendered in combination with railway=rail 102 lines earlier by a newer set of rules.
Attachments (0)
Change History (4)
follow-up: 2 comment:1 by , 13 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
comment:2 by , 13 years ago
Replying to bastiK:
They show a warning icon, when a node gets tagged servic=yard.
I take it you mean "when a node gets tagged ONLY service=yard", which makes sense, to catch the case where someone forgets to add railway=rail to the node. I assumed it was a dup/leftover because I thought there were generally not such rules in the style file - those which flag appearances of such "secondary" tags without appearance of the "primary" tags they are supposed to be used in combination with.
Wouldn't creation of lots of these add "clutter" to style files, and duplicate the work of the validator?
Or did I misunderstand?
comment:3 by , 13 years ago
You are right, but now that we have these rules, there is no reason to change the current situation.
They show a warning icon, when a node gets tagged servic=yard.