Modify

Opened 8 years ago

Closed 7 years ago

#7034 closed defect (fixed)

building inside building false positiv

Reported by: julien.balas@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

i don't know if the validator handle incorrectly "wall=no" or if the algorithm is too strict, but ther are some false alerts.

for example
http://www.openstreetmap.org/browse/way/81189416
and
http://www.openstreetmap.org/browse/way/81188636

Attachments (4)

area_inside_MP.osm (1.9 KB) - added by mdk 8 years ago.
Here is an example .osm file. Just validate.
7034.osm (23.2 KB) - added by JulienBalas 8 years ago.
a small test file. None of the small way "linked" to the big way should be reported as "in"
test.osm (2.0 KB) - added by jcr83 8 years ago.
Another false positive example.
covered_yard.osm (4.0 KB) - added by julien@… 8 years ago.
2 tests cases for a covered yard

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by mdk

An other fase positive is a building inside the inner of a building multipolygon:

 _______________̣_______    MP outer
|  MP building=yes     |
|  __________________  |   MP inner
| |                  | |
| |  ______________  | |
| | |              | | |   Building inside MP inner
| | | building=yes | | |   Validator mark this as "building in building" error
| | |              | | |
| | |______________| | |
| |__________________| |
|______________________|

mdk

comment:2 Changed 8 years ago by skyper

Think, this has to do with #4582.

It is always better to have a small .osm file test file, as objects might change on the server.

Changed 8 years ago by mdk

Attachment: area_inside_MP.osm added

Here is an example .osm file. Just validate.

Changed 8 years ago by JulienBalas

Attachment: 7034.osm added

a small test file. None of the small way "linked" to the big way should be reported as "in"

Changed 8 years ago by jcr83

Attachment: test.osm added

Another false positive example.

comment:3 Changed 8 years ago by Don-vip

In [4738/josm]:

see #7034 - building inside building false positives

comment:4 Changed 8 years ago by Don-vip

Problem fixed for 7034.osm and test.osm. The first example needs another fix.

comment:5 Changed 8 years ago by Don-vip

Resolution: fixed
Status: newclosed

In [4747/josm]:

fix #7034 - building inside building false positives

Changed 8 years ago by julien@…

Attachment: covered_yard.osm added

2 tests cases for a covered yard

comment:6 Changed 8 years ago by julien@…

Resolution: fixed
Status: closedreopened

The first example "area inside mp" seems to be also fixed, a building in a yard is correctly handled.
I'v added 1 new test file about covered yard (very common in french school)
The 2 example should not trigger the rule.

comment:7 Changed 7 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 5522/josm:

fix #7034, fix #8067 - Rework "Building inside Building" test from scratch

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.