Ability to add custom search from search dialog

[akks]

I suggest a simple patch that modifies search dialog (Ctrl-F).
The checkbox is added to use selected search expression as a temporary 'custom search button' on toolbar.
I am not sure if we need saving this button in preferences.

It is an easy solution for cases like ​http://josm.openstreetmap.de/ticket/6779 - preferences are too far for average user ( for me too :) ).

If something should be improved in this patch, I can do it (or someone else).

[akks]

No comments => no chance for this patch?

[stoecker]

Hmm, my comment must have been lost: The button is really temporary - As soon as you open prefs and save it is lost. This is a very unexpected behaviour.

[akks]

There is no big problem in saving these buttons, but how to clear them?
Make another window for editing search buttons?

By the way - is it possible to add simple context menu for toolbar buttons like "remove from panel"?

[bastiK]

Replying to akks:

By the way - is it possible to add simple context menu for toolbar buttons like "remove from panel"?

Sounds reasonable - that's how it works in the Opera Browser.

[akks]

Replying to bastiK:

Replying to akks:

By the way - is it possible to add simple context menu for toolbar buttons like "remove from panel"?

Sounds reasonable - that's how it works in the Opera Browser.

I have made a patch to add toolbar context menu ("remove button" and "show preferences" for now) and posted it in corresponding ticket:

​http://josm.openstreetmap.de/ticket/6953

There is unsolved problem - I do not know, how to show specific tab of preferences, not the first [without big refactoring].

Please have a look at it if you have some time.

If this patch will be applied, we can add custom search buttons permanently (I'll rewrite the SearchAction patch).

[akks]

In reworked version of the patch custom search buttons are saved in preferences (ToolbarPreferences classes are used).

To remove them from toolbar, user should go to toolbar preferences or use context menu proposed in ticket:6953.

[stoecker]

In [4587/josm]:

fix #6974 - patch by akks - Ability to add custom search from search dialog

[akks]

Thank you for really fast inclusion of the patches! :)

[bastiK]

The toolbar button is added at the left. This is unexpected.

[bastiK]

Also, it kills my toolbar:

• add button
• show tooltip for button

-> all buttons below tooltip are gone

next restart: only the search custom search button is there

[akks]

VERY strange! I can not reproduce it... (if "Show tooltip" means hold the mouse on the button).
(I am on Windows XP...)

Maybe, you are experimenting with preferences code?
Does it happen with clean preferences and josm-latest?

The adding code is

Collection<String> t = new LinkedList<String>(Main.pref.getCollection("toolbar"));
            if (t!=null) {
                // add custom search button to toolbar preferences
                if (!t.contains(res)) t.add(res);
                Main.pref.putCollection("toolbar", t);
                Main.toolbar.refreshToolbarControl();
            }

[bastiK]

In [4613/josm]:

see #6974 - fix problem caused by preference rework

[bastiK]

Replying to akks:

VERY strange! I can not reproduce it... (if "Show tooltip" means hold the mouse on the button).

Yes, apparently, it did not repaint properly after removing all the buttons.

Maybe, you are experimenting with preferences code?

You are exactly right. (Except I'm not experimenting, but it's supposed to work. :) )