Opened 14 years ago

Last modified 14 years ago

#6890 closed defect

[Patch needs review] Dragging map is considered moving objects — at Version 5

Reported by: Zverikk Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: move, drag Cc: malenki

Description (last modified by bastiK)

  1. Select more that 20 objects on a map
  2. Move them a bit (and click "yes" in "Are you sure?" window)
  3. Drag a map while pressing right mouse button on a selected object.

A confirmation window appears, like you've just dragged all the objects, but if you click "No", previous move action is undone.

Change History (6)

by Don-vip, 14 years ago

Attachment: patch.diff added

comment:1 by Don-vip, 14 years ago

Summary: Dragging map is considered moving objects[Patch] Dragging map is considered moving objects

Easily reproduced. I don't know if my patch is the best solution, but it fixes this issue without any visible side effect.

comment:2 by malenki, 14 years ago

Cc: malenki added

Confirm.
It doesn't matter if you click yes or no. Both ways JOSM falsely assumes you moved the objects.

comment:3 by Don-vip, 14 years ago

Summary: [Patch] Dragging map is considered moving objects[Patch needs review] Dragging map is considered moving objects

I'm not confident with my patch, especially on MacOS. I've only tested it under Windows, would someone test it on other platforms ?

comment:4 by rickmastfan67, 14 years ago

I just want to comment on this bug. On step #2, I can duplicate this when hitting "Undo Move" as well.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-10-05 01:31:44
Last Changed Author: Don-vip
Revision: 4488
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-10-04 13:00:33 +0200 (Tue, 04 Oct 2011)
Last Changed Rev: 4488

Identification: JOSM/1.5 (4488 en)
Memory Usage: 127 MB / 3640 MB (69 MB allocated, but free)
Java version: 1.6.0_27, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7
Last edited 14 years ago by rickmastfan67 (previous) (diff)

comment:5 by bastiK, 14 years ago

Description: modified (diff)

Why should it be platform dependent? Patch seems to work for me (Ubuntu Linux).

Note: See TracTickets for help on using tickets.