Modify

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#6858 closed defect (fixed)

[Patch] Unnecessary JMapViewer Dependencies

Reported by: jhuntley Owned by: team
Priority: major Milestone:
Component: Core Version: latest
Keywords: JMapViewer Cc:

Description

Someone recently introduced org.openstreetmap.gui.jmapviewer.MapRectangleImpl.java which introduced a ton of cross dependencies with unrelated classes to the project. I'm now having to bring in the whole josm project just to use the JMapViewer. The culprit imported class is org.openstreetmap.josm.data.Bounds. It cross references classes and static functions even in JOSM's Main.java, literally turning the once small project into a bloated dependency of various packages and classes in JOSM. It makes it difficult for those wanting to use and contribute to just the JMapViewer, as it's not longer an independent component. What I'd like to request is to make this Bounds class a composite singular entity rather than making all the cross references. Otherwise, is it possible to remove the references to the Bounds class and replace it with something more simple? I'll gladly help to resolve this entanglement. Thanks,

Attachments (1)

patch.diff (3.4 KB ) - added by Don-vip 14 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by jhuntley, 14 years ago

Work around to this is just to remove the MapRectangleImpl.java. I can use the JMapViewer without this class.

by Don-vip, 14 years ago

Attachment: patch.diff added

comment:2 by Don-vip, 14 years ago

I'm the one to blame for, sorry for that :( I've attached the patch that fixes this unintentional JOSM dependence.

comment:3 by Don-vip, 14 years ago

Priority: normalmajor
Summary: Unnecessary JMapViewer Dependencies[Patch] Unnecessary JMapViewer Dependencies

comment:4 by bastiK, 14 years ago

Resolution: fixed
Status: newclosed

In [4438/josm]:

applied #6858 - Unnecessary JMapViewer Dependencies (patch by Don-vip)

comment:5 by bastiK, 14 years ago

In [o26668].

comment:6 by jhuntley, 14 years ago

Thanks Don :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.