Reverse terracer broken, give number tag to unselected buildings

[skyper]

The reverse function is broken, if another building is attached. It leaves out the first + last new created buildings but give the addr:housenumber tag to the unselected building.

I attach an example.
I tried it with lowest number 80 and highest 88 on the souther building.

[skyper]

example osm file

[taylor.smock]

I think this is fixed, if I understood what the issue was.

[skyper]

Sorry, still an issue:

1. load attached file
2. select southern building
3. terrace using 80 as lowest and 88 as highest number
4. reverse a terrace

I expected the order of house numbers to be reversed but I get a total mess.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-10-23 21:06:35 +0200 (Mon, 23 Oct 2023)
Revision:18875
Build-Date:2023-10-24 01:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18875 en) Linux Debian GNU/Linux 12 (bookworm)
Memory Usage: 242 MB / 1970 MB (103 MB allocated, but free)
Java version: 17.0.8+7-Debian-1deb12u1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1366×768 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME
Java package: openjdk-17-jre:amd64-17.0.8+7-1~deb12u1
Java ATK Wrapper package: libatk-wrapper-java:all-0.40.0-3
fonts-noto: fonts-noto:all-20201225-1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djosm.dir.name=JOSM-latest, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ reverter (36126)
+ terracer (36178)
+ utilsplugin2 (36178)

[taylor.smock]

OK. I see the problem.

[taylor.smock]

In 36181/osm:

Fix #6855: Reverse terracer considers buildings without an address when reversing a terrace

This also fixes several lint issues.

[taylor.smock]

In 36182/osm:

See #6855 (dist): Reverse terracer considers buildings without an address when reversing a terrace