Modify

Opened 8 years ago

Closed 8 years ago

#6678 closed defect (fixed)

[Patch] Automatic tag correction (when reversing a way) should not attempt to change "FIXME" tags.

Reported by: rickmastfan67 Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

  1. Download attachment.
  2. Hit "r" to reverse the only way in the file (once the way is selected of course).

What should happen: The way should be reversed without having the "Automatic tag correction" screen show up suggesting a change of the "FIXME" tag because the first word in it is "Western".

What does happen: The "Automatic tag correction" shows up suggesting that the word "Western" be changed to "eastern" in the "FIXME" tag.

=====

The "FIXME" tag should never be suggested for an "Automatic tag correction" because of people intentionally putting the specific "side" (Western, Eastern, Northern, Southern) of the road that needs to be fixed (for whatever reason). When just revering a way, it doesn't effect whatever cardinal direction is mentioned because the way itself hasn't been changed, just the order of the nodes has been.

NOTE: This only happens when the first word in the "FIXME" tag is a cardinal direction. If any other word starts off the "FIXME" tag, this problem doesn't happen.

Attachments (2)

ticket6678.osm (6.1 KB) - added by rickmastfan67 8 years ago.
6678.patch (1.3 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by rickmastfan67

Attachment: ticket6678.osm added

comment:1 Changed 8 years ago by rickmastfan67

BTW, I've updated the way in the OSM data and removed the FIXME tag because of fixing it, hence why it's an attachment instead of a way ID for this ticket.

Changed 8 years ago by simon04

Attachment: 6678.patch added

comment:2 Changed 8 years ago by simon04

Summary: Automatic tag correction (when reversing a way) should not attempt to change "FIXME" tags.[Patch] Automatic tag correction (when reversing a way) should not attempt to change "FIXME" tags.

Patch attached. The following keys are ignored for this kind of tag correction (the first two have been there previously):

key.startsWith("name") || key.endsWith("name") || key.equalsIgnoreCase("fixme") || key.startsWith("note")
Last edited 8 years ago by simon04 (previous) (diff)

comment:3 Changed 8 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4345/josm]:

fix #6678 - patch by simon04 - don't suggest tag correction for comments

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.