[PATCH] Members list in history panel for relations and ways is broken

[Zverikk]

1. Select a relation with more than one version
2. Open history panel and click "Show"
3. Select "Members" tab
4. Observe the left table. It shows one member all the way and has no sense.

[Don-vip]

Could you attach a screenshot explaining the problem ? I don't understand your concern.

[Zverikk]

I've desribed the bug incorrectly. Actually, there are two list of nodes for a way (or nodes+ways for a relation) in history window, "Members" tab. They are always of the same size, regardless of actual number of nodes. Lists are padded with the last node ID, resulting in a sequence of repeating IDs, making no sense. Empty lines should be shown instead. Check right column on the screenshot.

[olejorgenb]

Patch attached.

PS: The node list for way-history has the same problem

Off topic: The HistoryBrowserModel has lots of code sections like this:

if (pointInTimeType.equals(PointInTimeType.CURRENT_POINT_IN_TIME)) {
    if (! current.getType().equals(OsmPrimitiveType.WAY))
        return null;
    return (HistoryWay)current;
}
if (pointInTimeType.equals(PointInTimeType.REFERENCE_POINT_IN_TIME)) {
    if (! reference.getType().equals(OsmPrimitiveType.WAY))
        return null;
    return (HistoryWay)reference;
}

I think HistoryBrowserModel could be simplified a lot by adding a getTargetIfValid method or maybe storing the target directly in the sub-models.

I could do something like that if it's not considered to much a case of "If It Ain't Broke, Don't Fix It"

[olejorgenb]

Ups, that approach screwed up the scrollbar sync. Better patch attached.

[stoecker]

In [4566/josm]:

fix #6652 - patch by olejorgenb - Members list in history panel for relations and ways is broken