Modify

Opened 14 years ago

Closed 13 years ago

#6594 closed defect (fixed)

Changeset manager does not support OAuth

Reported by: Don-vip Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: oauth Cc:

Description

The button "Download my changesets" in changeset manager does not work if OAuth is the chosen authentication method in JOSM.

Attachments (0)

Change History (9)

comment:1 by Cobra, 14 years ago

Resolution: worksforme
Status: newclosed

cannot reproduce with r4376.

comment:2 by Don-vip, 14 years ago

It is still not working with me, with r4379.
When I click on "Download my changesets" button, I have a popup window saying that JOSM runs in anonymous mode and thereby cannot download the changesets. Of course JOSM is NOT in anonymous mode as I can edit without any difficulties, there is a problem in Changeset manager. I thought it was related with OAuth, maybe it's not ?

comment:3 by Cobra, 14 years ago

Did you set your username in the preferences?

I got this message when using a blank preferences file and it disappeared after I entered a username.

comment:4 by Don-vip, 14 years ago

OK, it's working after setting the username. Thanks. The error message is just a bit odd. Rather than saying JOSM is running in anonymous mode whereas OAuth is perfectly configured, it should be more something like "username cannot be deduced form OAuth and must be set in standard authentification panel without having to set a password".

in reply to:  4 comment:5 by fabrizio.benedetti@…, 13 years ago

I had been tricked into thinking that JOSM "Changeset manager does not support OAuth". Now I know (and I verified) that "username cannot be deduced form OAuth and must be set in standard authentification panel without having to set a password"... thanks"

comment:6 by KalleLampila, 13 years ago

Resolution: worksforme
Status: closedreopened

comment:7 by Cobra, 13 years ago

@Kalle Lampila: why did you reopen this?

comment:8 by KalleLampila, 13 years ago

Like comment:3 says problem is still valid (also in r4613). Username and userid can ask form server based on Oauth like "test Access" button do in Oauth authentication settings and this method is used elsewhere where Josm need username like upload dialog reload open changesets.

comment:9 by Don-vip, 13 years ago

Resolution: fixed
Status: reopenedclosed

In 5434/josm:

fix #6594 - Fetch user details with supplied OAuth credentials to download changesets without having to set user name in "Basic authentication" tab + fix a bug in languages parsing

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.